From: Andi Kleen <ak@suse.de>
To: Adrian Bunk <bunk@stusta.de>
Cc: ak@suse.de, discuss@x86-64.org, linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] x86_64: kill stale mtrr_centaur_report_mcr
Date: Mon, 17 Jan 2005 06:50:40 +0100 [thread overview]
Message-ID: <20050117055040.GE19187@wotan.suse.de> (raw)
In-Reply-To: <20050116074817.GX4274@stusta.de>
On Sun, Jan 16, 2005 at 08:48:17AM +0100, Adrian Bunk wrote:
> I didn't know the x86_64 port supports the Centaur CPU. ;-)
Have you actually compiled this? Most of the gunk in asm-x86_64/mtrr.h
is because we share the MTRR driver with i386, and there is no good
way to disable specific CPUs in there.
-Andi
>
>
> diffstat output:
> include/asm-x86_64/mtrr.h | 3 ---
> 1 files changed, 3 deletions(-)
>
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
>
> --- linux-2.6.11-rc1-mm1-full/include/asm-x86_64/mtrr.h.old 2005-01-16 04:27:41.000000000 +0100
> +++ linux-2.6.11-rc1-mm1-full/include/asm-x86_64/mtrr.h 2005-01-16 04:27:54.000000000 +0100
> @@ -79,7 +79,6 @@
> unsigned int type, char increment);
> extern int mtrr_del (int reg, unsigned long base, unsigned long size);
> extern int mtrr_del_page (int reg, unsigned long base, unsigned long size);
> -extern void mtrr_centaur_report_mcr(int mcr, u32 lo, u32 hi);
> # else
> static __inline__ int mtrr_add (unsigned long base, unsigned long size,
> unsigned int type, char increment)
> @@ -102,8 +101,6 @@
> return -ENODEV;
> }
>
> -static __inline__ void mtrr_centaur_report_mcr(int mcr, u32 lo, u32 hi) {}
> -
> # endif
>
> #endif
>
next prev parent reply other threads:[~2005-01-17 5:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-16 7:48 Adrian Bunk
2005-01-17 5:50 ` Andi Kleen [this message]
2005-01-17 6:07 ` Adrian Bunk
2005-01-17 6:16 ` Andi Kleen
2005-01-17 8:43 ` Adrian Bunk
2005-01-17 9:25 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050117055040.GE19187@wotan.suse.de \
--to=ak@suse.de \
--cc=bunk@stusta.de \
--cc=discuss@x86-64.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®