From: Chip Salzenberg <chip@pobox.com>
To: Linux Kernel <linux-kernel@vger.kernel.org>
Subject: [PATCH] restore skb_copy_datagram, removed from 2.6.11-rc2, breaking VMWare
Date: Sat, 22 Jan 2005 11:01:29 -0500 [thread overview]
Message-ID: <20050122160129.GA4693@perlsupport.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 384 bytes --]
Those of you who are using VMWare 4.5 will find that 2.6.11-rc2
removes the public function "skb_copy_datagram", breaking VMWare
(and any other module using that interface *sigh*).
The attached patch restores the (little harmless wrapper) function.
--
Chip Salzenberg - a.k.a. - <chip@pobox.com>
"What I cannot create, I do not understand." - Richard Feynman
[-- Attachment #2: skb.diff --]
[-- Type: text/plain, Size: 1208 bytes --]
--- x/include/linux/skbuff.h.old 2005-01-22 10:03:55.000000000 -0500
+++ y/include/linux/skbuff.h 2005-01-22 10:42:33.000000000 -0500
@@ -1087,4 +1087,6 @@
extern unsigned int datagram_poll(struct file *file, struct socket *sock,
struct poll_table_struct *wait);
+extern int skb_copy_datagram(const struct sk_buff *from,
+ int offset, char __user *to, int size);
extern int skb_copy_datagram_iovec(const struct sk_buff *from,
int offset, struct iovec *to,
--- x/net/core/datagram.c.old 2005-01-22 10:03:56.000000000 -0500
+++ y/net/core/datagram.c 2005-01-22 10:43:40.000000000 -0500
@@ -200,4 +200,17 @@
}
+/*
+ * Copy a datagram to a linear buffer.
+ */
+int skb_copy_datagram(const struct sk_buff *skb, int offset, char __user *to, int size)
+{
+ struct iovec iov = {
+ .iov_base = to,
+ .iov_len =size,
+ };
+
+ return skb_copy_datagram_iovec(skb, offset, &iov, size);
+}
+
/**
* skb_copy_datagram_iovec - Copy a datagram to an iovec.
@@ -478,4 +491,5 @@
EXPORT_SYMBOL(datagram_poll);
EXPORT_SYMBOL(skb_copy_and_csum_datagram_iovec);
+EXPORT_SYMBOL(skb_copy_datagram);
EXPORT_SYMBOL(skb_copy_datagram_iovec);
EXPORT_SYMBOL(skb_free_datagram);
next reply other threads:[~2005-01-22 16:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-22 16:01 Chip Salzenberg [this message]
2005-01-22 16:16 ` Christoph Hellwig
2005-01-22 16:26 ` Petr Vandrovec
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050122160129.GA4693@perlsupport.com \
--to=chip@pobox.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®