From: Andi Kleen <ak@suse.de>
To: Chuck Ebbert <76306.1226@compuserve.com>
Cc: Matt Mackall <mpm@selenic.com>, "Theodore Ts'o" <tytso@mit.edu>,
Andrew Morton <akpm@osdl.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Andi Kleen <ak@suse.de>
Subject: Re: [PATCH 1/12] random pt4: Create new rol32/ror32 bitops
Date: Sun, 23 Jan 2005 04:19:21 +0100 [thread overview]
Message-ID: <20050123031921.GA1660@wotan.suse.de> (raw)
In-Reply-To: <200501222113_MC3-1-940A-5393@compuserve.com>
On Sat, Jan 22, 2005 at 09:10:40PM -0500, Chuck Ebbert wrote:
> On Fri, 21 Jan 2005 at 15:41:06 -0600 Matt Mackall wrote:
>
> > Add rol32 and ror32 bitops to bitops.h
>
> Can you test this patch on top of yours? I did it on 2.6.10-ac10 but it
> should apply OK. Compile tested and booted, but only random.c is using it
> in my kernel.
Does random really use variable rotates? For constant rotates
gcc detects the usual C idiom and turns it transparently into
the right machine instruction.
If that's the case I would use it because it'll avoid some messy
code everywhere.
-Andi
next prev parent reply other threads:[~2005-01-23 3:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-23 2:10 Chuck Ebbert
2005-01-23 2:45 ` Matt Mackall
2005-01-23 3:19 ` Andi Kleen [this message]
2005-01-23 4:13 ` Matt Mackall
-- strict thread matches above, loose matches on Subject: below --
2005-01-23 7:44 Chuck Ebbert
2005-01-24 22:16 ` H. Peter Anvin
2005-01-21 21:41 [PATCH 0/12] random pt4: Moving and sharing code Matt Mackall
2005-01-21 21:41 ` [PATCH 1/12] random pt4: Create new rol32/ror32 bitops Matt Mackall
2005-01-25 21:02 ` Denis Vlasenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050123031921.GA1660@wotan.suse.de \
--to=ak@suse.de \
--cc=76306.1226@compuserve.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpm@selenic.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome