From: Matt Mackall <mpm@selenic.com>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/8] core-small: Introduce CONFIG_CORE_SMALL from -tiny
Date: Sun, 23 Jan 2005 18:50:34 -0800 [thread overview]
Message-ID: <20050124025034.GW12076@waste.org> (raw)
In-Reply-To: <20050123130514.0a9656bb.akpm@osdl.org>
On Sun, Jan 23, 2005 at 01:05:14PM -0800, Andrew Morton wrote:
> Matt Mackall <mpm@selenic.com> wrote:
> >
> > > I wish it didn't have "core" in the name. A little misleading.
> >
> > Well I've got another set called NET_SMALL. BASE?
>
> BASE works, I guess.
>
> > > #define PID_MAX_DEFAULT (CONFIG_CORE_SMALL ? 0x1000 : 0x8000)
> > > #define UIDHASH_BITS (CONFIG_CORE_SMALL ? 3 : 8)
> > > #define FUTEX_HASHBITS (CONFIG_CORE_SMALL ? 4 : 8)
> > > etc.
> >
> > Hmm. I think we'd want a hidden config variable for this and I'm not
> > sure how well the config language allows setting an int from a bool.
>
> config AKPM_BOOL
> bool "akpm"
>
> config AKPM_INT
> int
> default 1 if AKPM_BOOL
> default 0 if !AKPM_BOOL
>
> seems to do everything which it should.
>
> > And then it would need another name. On the whole, seems more complex
> > than what I've done.
>
> No, it's quite simple and avoids lots of ifdeffing.
Ok, will respin these Monday.
--
Mathematics is the supreme nostalgia of our time.
next prev parent reply other threads:[~2005-01-24 2:50 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-22 0:09 Matt Mackall
2005-01-22 0:09 ` [PATCH 1/8] core-small: Add option to embedded menu Matt Mackall
2005-01-22 0:09 ` [PATCH 2/8] core-small: Collapse major names hash Matt Mackall
2005-01-22 0:09 ` [PATCH 3/8] core-small: Collapse chrdevs hash Matt Mackall
2005-01-22 0:09 ` [PATCH 4/8] core-small: Shrink PID lookup tables Matt Mackall
2005-01-22 0:09 ` [PATCH 5/8] core-small: Shrink uid hash Matt Mackall
2005-01-22 0:09 ` [PATCH 6/8] core-small: Shrink futex queue hash Matt Mackall
2005-01-22 0:09 ` [PATCH 7/8] core-small: Shrink timer lists Matt Mackall
2005-01-22 0:09 ` [PATCH 8/8] core-small: Shrink console buffer Matt Mackall
2005-01-23 8:40 ` [PATCH 0/8] core-small: Introduce CONFIG_CORE_SMALL from -tiny Andrew Morton
2005-01-23 17:52 ` Matt Mackall
2005-01-23 21:05 ` Andrew Morton
2005-01-24 2:50 ` Matt Mackall [this message]
2005-01-24 20:00 ` Alan Cox
2005-01-24 22:47 ` Tim Bird
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050124025034.GW12076@waste.org \
--to=mpm@selenic.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome