From: Pavel Machek <pavel@ucw.cz>
To: Matthew Garrett <mgarrett@chiark.greenend.org.uk>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Enable swsusp on SMP machines
Date: Tue, 25 Jan 2005 09:42:31 +0100 [thread overview]
Message-ID: <20050125084231.GC1369@elf.ucw.cz> (raw)
In-Reply-To: <E1Ct8zE-0002TK-00@chiark.greenend.org.uk>
Hi!
> > - /* Suspend is hard to get right on SMP. */
> > - if (num_online_cpus() != 1) {
> > - error = -EPERM;
> > + if (state == PM_SUSPEND_DISK) {
> > + error = pm_suspend_disk();
> > goto Unlock;
> > }
> >
> > - if (state == PM_SUSPEND_DISK) {
> > - error = pm_suspend_disk();
> > + /* Suspend is hard to get right on SMP. */
> > + if (num_online_cpus() != 1) {
> > + error = -EPERM;
> > goto Unlock;
> > }
>
> Are you sure about this?
Yes, as we already agreed on in private mails ;-). The diff really is
confusing.
Pavel
--
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!
prev parent reply other threads:[~2005-01-25 8:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-24 17:19 Pavel Machek
2005-01-24 18:30 ` Matthew Garrett
2005-01-25 8:42 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050125084231.GC1369@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=mgarrett@chiark.greenend.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome