From: Matt Mackall <mpm@selenic.com>
To: Andrew Morton <akpm@osdl.org>, "Theodore Y. Ts'o" <tytso@MIT.EDU>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: [PATCH] rol32 thinko
Date: Tue, 25 Jan 2005 12:42:19 -0800 [thread overview]
Message-ID: <20050125204219.GM12076@waste.org> (raw)
This thinko.. makes things a bit more arbitrary than we'd like. I've
re-audited the other rotate conversions.
Signed-off-by: Matt Mackall <mpm@selenic.com>
Index: rc2mm1/drivers/char/random.c
===================================================================
--- rc2mm1.orig/drivers/char/random.c 2005-01-25 12:26:13.000000000 -0800
+++ rc2mm1/drivers/char/random.c 2005-01-25 12:27:00.000000000 -0800
@@ -474,7 +474,7 @@
add_ptr = r->add_ptr;
while (nwords--) {
- w = rol32(input_rotate, next_w);
+ w = rol32(next_w, input_rotate);
if (nwords > 0)
next_w = *in++;
i = add_ptr = (add_ptr - 1) & wordmask;
--
Mathematics is the supreme nostalgia of our time.
reply other threads:[~2005-01-25 20:46 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050125204219.GM12076@waste.org \
--to=mpm@selenic.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@MIT.EDU \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®