mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: brking@us.ibm.com
To: greg@kroah.com
Cc: linux-kernel@vger.kernel.org, brking@us.ibm.com
Subject: [PATCH 1/1] pci: Add Citrine quirk
Date: Fri, 28 Jan 2005 08:53:47 -0600	[thread overview]
Message-ID: <200501281453.j0SErn7w002778@d03av02.boulder.ibm.com> (raw)


The IBM Citrine chipset has a feature that if PCI config register
0xA0 is read while DMAs are being performed to it, there is the possiblity
that the parity will be wrong on the PCI bus, causing a parity error and
a master abort. On this chipset, this register is simply a debug register
for the chip developers and the registers after it are not defined.
Patch sets cfg_size to 0xA0 to prevent this problem from being seen.

Signed-off-by: Brian King <brking@us.ibm.com>
---

 linux-2.6.11-rc2-bk5-bjking1/drivers/pci/quirks.c |   10 ++++++++++
 1 files changed, 10 insertions(+)

diff -puN drivers/pci/quirks.c~pci_citrine_quirk drivers/pci/quirks.c
--- linux-2.6.11-rc2-bk5/drivers/pci/quirks.c~pci_citrine_quirk	2005-01-27 16:51:28.000000000 -0600
+++ linux-2.6.11-rc2-bk5-bjking1/drivers/pci/quirks.c	2005-01-27 16:51:28.000000000 -0600
@@ -216,6 +216,16 @@ DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_IN
 DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_INTEL, 	PCI_DEVICE_ID_INTEL_82443BX_2, 	quirk_natoma );
 
 /*
+ *  This chip can cause PCI parity errors if config register 0xA0 is read
+ *  while DMAs are occurring.
+ */
+static void __devinit quirk_citrine(struct pci_dev *dev)
+{
+	dev->cfg_size = 0xA0;
+}
+DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_IBM,	PCI_DEVICE_ID_IBM_CITRINE,	quirk_citrine );
+
+/*
  *  S3 868 and 968 chips report region size equal to 32M, but they decode 64M.
  *  If it's needed, re-allocate the region.
  */
_

             reply	other threads:[~2005-01-28 14:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-01-28 14:53 brking [this message]
2005-01-28 14:24 ` IBM SerialRAID shogunx
2005-02-01  0:15 ` [PATCH 1/1] pci: Add Citrine quirk Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200501281453.j0SErn7w002778@d03av02.boulder.ibm.com \
    --to=brking@us.ibm.com \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®