From: John Levon <levon@movementarian.org>
To: Zwane Mwaikambo <zwane@arm.linux.org.uk>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH] OProfile: Fix oops on undetected CPU type
Date: Sat, 29 Jan 2005 21:36:42 +0000 [thread overview]
Message-ID: <20050129213642.GB71581@compsoc.man.ac.uk> (raw)
In-Reply-To: <Pine.LNX.4.61.0501290941180.10009@montezuma.fsmlabs.com>
On Sat, Jan 29, 2005 at 09:47:42AM -0700, Zwane Mwaikambo wrote:
> > Unfortunately bkcvs seems out of date so I can't even look at this
> > myself.
>
> Yes you are right, i checked bk and there was a lot of shuffling about due
> to the timer override. But it looks like we're depending on the timer
> variable being set. We could always just run timer_init if cpu_type is not
> set.
>
> Signed-off-by: Zwane Mwaikambo <zwane@arm.linux.org.uk>
>
> ===== drivers/oprofile/oprof.c 1.11 vs edited =====
> --- 1.11/drivers/oprofile/oprof.c 2005-01-04 19:48:23 -07:00
> +++ edited/drivers/oprofile/oprof.c 2005-01-29 09:38:24 -07:00
> @@ -157,7 +157,7 @@ static int __init oprofile_init(void)
>
> oprofile_arch_init(&oprofile_ops);
>
> - if (timer) {
> + if (timer || !oprofile_ops.cpu_type) {
Looks like you're still on the broken bkcvs, which is missing this
patch:
http://linus.bkbits.net:8080/linux-2.5/cset@1.1966.1.72?nav=index.html|ChangeSet@-2w
which AFAICS is the correct solution to the problem.
regards,
john
next prev parent reply other threads:[~2005-01-29 21:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-28 19:06 Zwane Mwaikambo
2005-01-29 14:04 ` John Levon
2005-01-29 16:47 ` Zwane Mwaikambo
2005-01-29 21:36 ` John Levon [this message]
2005-01-29 22:01 ` Zwane Mwaikambo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050129213642.GB71581@compsoc.man.ac.uk \
--to=levon@movementarian.org \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zwane@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®