From: Vojtech Pavlik <vojtech@suse.cz>
To: Dmitry Torokhov <dtor_core@ameritech.net>
Cc: Al Viro <viro@parcelfarce.linux.theplanet.co.uk>,
Roman Zippel <zippel@linux-m68k.org>,
Andries Brouwer <aebr@win.tue.nl>,
linux-kernel@vger.kernel.org
Subject: Re: Possible bug in keyboard.c (2.6.10)
Date: Mon, 31 Jan 2005 10:01:26 +0100 [thread overview]
Message-ID: <20050131090126.GB27820@ucw.cz> (raw)
In-Reply-To: <200501291835.59597.dtor_core@ameritech.net>
On Sat, Jan 29, 2005 at 06:35:59PM -0500, Dmitry Torokhov wrote:
> On Saturday 29 January 2005 06:25, Vojtech Pavlik wrote:
> > On Sat, Jan 29, 2005 at 04:50:55AM +0000, Al Viro wrote:
> >
> > > > I'm very sorry about the locking, but the thing grew up in times of
> > > > kernel 2.0, which didn't require any locking. There are a few possible
> > >
> > > Incorrect. You have blocking allocations in critical areas and they
> > > required locking all way back.
> >
> > Ok. I see a problem where input_register_device() calls input handler
> > connect methods, which do kmalloc(). This would be bad even on 2.0.
> >
> > Anything else? I believe the ->open()/->release() methods are still
> > protected.
> >
>
> evdev, tsdev, mousedev, joydev need to protect their client lists because
> interrupt could try to deliver event to already deleted device (client)
Oh, of course. The protection doesn't apply to the event routine.
--
Vojtech Pavlik
SuSE Labs, SuSE CR
next prev parent reply other threads:[~2005-01-31 8:57 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-27 3:16 Sasa Stevanovic
2005-01-27 4:50 ` Dmitry Torokhov
2005-01-27 10:16 ` Sasa Stevanovic
2005-01-27 12:56 ` Andries Brouwer
2005-01-28 0:39 ` Roman Zippel
2005-01-28 10:59 ` Vojtech Pavlik
2005-01-29 4:50 ` Al Viro
2005-01-29 11:25 ` Vojtech Pavlik
2005-01-29 23:35 ` Dmitry Torokhov
2005-01-31 9:01 ` Vojtech Pavlik [this message]
2005-01-30 8:41 ` Al Viro
2005-01-30 23:21 ` Dmitry Torokhov
2005-01-30 23:29 ` Dmitry Torokhov
2005-02-03 6:54 ` Dmitry Torokhov
2005-01-29 12:11 ` Roman Zippel
2005-01-29 14:04 ` Vojtech Pavlik
2005-01-30 20:13 ` Roman Zippel
2005-01-28 11:10 ` Vojtech Pavlik
2005-01-28 21:59 ` Andries Brouwer
2005-01-29 11:12 ` Vojtech Pavlik
2005-01-29 23:30 ` Dmitry Torokhov
2005-01-30 23:16 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050131090126.GB27820@ucw.cz \
--to=vojtech@suse.cz \
--cc=aebr@win.tue.nl \
--cc=dtor_core@ameritech.net \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@parcelfarce.linux.theplanet.co.uk \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®