From: "David S. Miller" <davem@davemloft.net>
To: "Einar Lück" <lkml@einar-lueck.de>
Cc: linux-kernel@vger.kernel.org, netdev@oss.sgi.com
Subject: Re: [PATCH 1/2] ipv4 routing: splitting of ip_route_[in|out]put_slow, 2.6.10-rc3
Date: Wed, 2 Feb 2005 17:17:01 -0800 [thread overview]
Message-ID: <20050202171701.18a81a6a.davem@davemloft.net> (raw)
In-Reply-To: <41C6B3D4.6060207@einar-lueck.de>
On Mon, 20 Dec 2004 12:13:24 +0100
Einar Lück <lkml@einar-lueck.de> wrote:
> This patch splits up ip_route_[in|out]put_slow in inlined functions.
> Basic idea:
> * improve overall comprehensibility
> * allow for an easier application of patch for improved multipath
> support
Patch applied to my 2.6.12 pending tree. Thanks a lot Einar.
One minor comment is that there are some minor cases where
excessing in_dev get/put can be eliminated. For example,
in __mkroute_output() we really only need to do the
in_dev_get(dev_out) once, yet we do it twice due to how
the return path of this function always puts the reference
even in the non-error case.
prev parent reply other threads:[~2005-02-03 1:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-20 11:13 Einar Lück
2004-12-20 14:02 ` Patrick McHardy
2004-12-20 15:08 ` Einar Lück
2005-02-03 1:17 ` David S. Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050202171701.18a81a6a.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=lkml@einar-lueck.de \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®