mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chris Wright <chrisw@osdl.org>
To: Stephen Smalley <sds@tycho.nsa.gov>
Cc: Andrew Morton <akpm@osdl.org>, James Morris <jmorris@redhat.com>,
	Chris Wright <chrisw@osdl.org>,
	lkml <linux-kernel@vger.kernel.org>,
	selinux@tycho.nsa.gov
Subject: Re: [PATCH][SELINUX] Fix selinux_inode_setattr hook
Date: Fri, 4 Feb 2005 10:14:40 -0800	[thread overview]
Message-ID: <20050204101440.N24171@build.pdx.osdl.net> (raw)
In-Reply-To: <1107539956.8078.109.camel@moss-spartans.epoch.ncsc.mil>; from sds@tycho.nsa.gov on Fri, Feb 04, 2005 at 12:59:16PM -0500

* Stephen Smalley (sds@tycho.nsa.gov) wrote:
> This patch against 2.6.11-rc3 fixes the selinux_inode_setattr hook
> function to honor the ATTR_FORCE flag, skipping any permission checking
> in that case.  Otherwise, it is possible though unlikely for a denial
> from the hook to prevent proper updating, e.g. for remove_suid upon
> writing to a file.  This would only occur if the process had write
> permission to a suid file but lacked setattr permission to it.  Please
> apply.

Is there any reason not to promote this to the framework?

thanks,
-chris
-- 
Linux Security Modules     http://lsm.immunix.org     http://lsm.bkbits.net

  reply	other threads:[~2005-02-04 19:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-02-04 17:59 Stephen Smalley
2005-02-04 18:14 ` Chris Wright [this message]
2005-02-04 18:13   ` Stephen Smalley
2005-02-04 18:27     ` Chris Wright

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050204101440.N24171@build.pdx.osdl.net \
    --to=chrisw@osdl.org \
    --cc=akpm@osdl.org \
    --cc=jmorris@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sds@tycho.nsa.gov \
    --cc=selinux@tycho.nsa.gov \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®