From: Grant Grundler <grundler@parisc-linux.org>
To: Jean Delvare <khali@linux-fr.org>
Cc: Enrico Bartky <DOSProfi@web.de>,
linux-pci@atrey.karlin.mff.cuni.cz,
LM Sensors <sensors@stimpy.netroedge.com>,
LKML <linux-kernel@vger.kernel.org>,
Maarten Deprez <maartendeprez@scarlet.be>,
Greg KH <gregkh@suse.de>
Subject: Re: M7101
Date: Sun, 6 Feb 2005 20:42:19 -0700 [thread overview]
Message-ID: <20050207034219.GA5620@colo.lackof.org> (raw)
In-Reply-To: <20050206152615.1ab7498c.khali@linux-fr.org>
On Sun, Feb 06, 2005 at 03:26:15PM +0100, Jean Delvare wrote:
> Maarten Deprez then converted it to the proper kernel coding-style:
> http://marc.theaimsgroup.com/?l=linux-kernel&m=110726276414532
...
> Any chance we could get the PCI folks to review the code and push it
> upwards if it is OK?
I'm not the maintainer, but it looks fine to me except for use
of numeric constants (e.g 0x5f, 0x18) instead of adding #defines
to name the values. But if no one knows what those offsets are for
we'll just have to leave it.
> For reference, here are links to the original m7101 unhiding driver code
> and help file:
> http://www2.lm-sensors.nu/~lm78/cvs/lm_sensors2/prog/hotplug/m7101.c
Unfortunately, I didn't anything documenting 0x5f and 0x18.
Will m7101.c be modified once quirks enabling the device?
hth,
grant
next prev parent reply other threads:[~2005-02-07 3:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-05 21:18 M7101 Enrico Bartky
2005-02-06 14:26 ` M7101 Jean Delvare
2005-02-06 15:06 ` M7101 Matthew Wilcox
2005-02-08 11:13 ` M7101 Ivan Kokshaysky
2005-02-08 20:39 ` M7101 Ondrej Zary
2005-02-07 3:42 ` Grant Grundler [this message]
2005-02-12 18:52 ` M7101 Jean Delvare
2005-02-07 20:43 ` M7101 Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050207034219.GA5620@colo.lackof.org \
--to=grundler@parisc-linux.org \
--cc=DOSProfi@web.de \
--cc=gregkh@suse.de \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=maartendeprez@scarlet.be \
--cc=sensors@stimpy.netroedge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome