mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Matthew Wilcox <matthew@wil.cx>
To: Matthew Wilcox <matthew@wil.cx>,
	Roman Zippel <zippel@linux-m68k.org>,
	Sam Ravnborg <sam@ravnborg.org>,
	Kai Germaschewski <kai@germaschewski.name>,
	linux-kernel@vger.kernel.org, dholland@eecs.harvard.edu
Subject: Re: [PATCH] Makefiles are not built using a Fortran compiler
Date: Tue, 8 Feb 2005 21:27:20 +0000	[thread overview]
Message-ID: <20050208212720.GI20386@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <20050208192027.GA8360@mars.ravnborg.org>

On Tue, Feb 08, 2005 at 08:20:27PM +0100, Sam Ravnborg wrote:
> In my inbox I have a patch that enables SCCS support for all files.
> Today it fails for Kconfig files at least.

I guess the kconfig system needs to try to make Kconfig files before
including them ... this works for me, checking a Kconfig file out of RCS:

--- scripts/kconfig/zconf.l     29 Jul 2003 17:02:27 -0000      1.1
+++ scripts/kconfig/zconf.l     8 Feb 2005 21:25:43 -0000
@@ -269,15 +269,24 @@ static void zconf_endhelp(void)
  */
 FILE *zconf_fopen(const char *name)
 {
-       char *env, fullname[PATH_MAX+1];
+       char *env, fullname[PATH_MAX+6];
        FILE *f;
 
        f = fopen(name, "r");
+       if (!f) {
+               sprintf(fullname, "make %s", name);
+               system(fullname);
+               f = fopen(name, "r");
+       }
        if (!f && name[0] != '/') {
                env = getenv(SRCTREE);
                if (env) {
-                       sprintf(fullname, "%s/%s", env, name);
-                       f = fopen(fullname, "r");
+                       sprintf(fullname, "make %s/%s", env, name);
+                       f = fopen(fullname + 5, "r");
+                       if (!f) {
+                               system(fullname);
+                               f = fopen(fullname + 5, "r");
+                       }
                }
        }
        return f;

I bet someone else can do it better than this ... I'm sure we don't need
to invoke sh to invoke make ;-)

> I'm willing to give it a try. But we will only see people complaining
> when it hits linus tree. -mm users uses quilt and the like - and thus
> will not be hit by this.
> 
> 	Sam

-- 
"Next the statesmen will invent cheap lies, putting the blame upon 
the nation that is attacked, and every man will be glad of those
conscience-soothing falsities, and will diligently study them, and refuse
to examine any refutations of them; and thus he will by and by convince 
himself that the war is just, and will thank God for the better sleep 
he enjoys after this process of grotesque self-deception." -- Mark Twain

  parent reply	other threads:[~2005-02-08 21:28 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-02-08  3:02 Matthew Wilcox
2005-02-08 12:23 ` Roman Zippel
2005-02-08 15:44   ` Matthew Wilcox
2005-02-08 17:04     ` Ryan Anderson
2005-02-08 19:20     ` Sam Ravnborg
2005-02-08 19:26       ` Kai Germaschewski
2005-02-09  5:04         ` Sam Ravnborg
2005-02-08 21:27       ` Matthew Wilcox [this message]
2005-02-08 21:23     ` J.A. Magallon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050208212720.GI20386@parcelfarce.linux.theplanet.co.uk \
    --to=matthew@wil.cx \
    --cc=dholland@eecs.harvard.edu \
    --cc=kai@germaschewski.name \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sam@ravnborg.org \
    --cc=zippel@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®