From: Kurt Garloff <garloff@suse.de>
To: James Morris <jmorris@redhat.com>
Cc: Linux kernel list <linux-kernel@vger.kernel.org>,
Andreas Gruenbacher <agruen@suse.de>,
Chris Wright <chrisw@osdl.org>,
Stephen Smalley <sds@epoch.ncsc.mil>
Subject: Re: [PATCH] 5/5: LSM hooks rework
Date: Tue, 15 Feb 2005 00:23:25 +0100 [thread overview]
Message-ID: <20050214232325.GI18744@tpkurt.garloff.de> (raw)
In-Reply-To: <Xine.LNX.4.44.0502141143420.24807-100000@thoron.boston.redhat.com>
[-- Attachment #1: Type: text/plain, Size: 893 bytes --]
Hi James,
On Mon, Feb 14, 2005 at 11:50:01AM -0500, James Morris wrote:
> On Sun, 13 Feb 2005, Kurt Garloff wrote:
>
> > /* Condition for invocation of non-default security_op */
> > #define COND_SECURITY(seop, def) \
> > - (likely(security_ops == &capability_security_ops))? def: security_ops->seop
> > + (unlikely(security_enabled))? security_ops->seop: def
>
> So this will cause a false unlikely() for every single SELinux hook,
> again.
A correct unlikely() in my book.
Yes, that was one of the reasons that I split up the patches.
There are people who believe that we should optimize for the
slow path (SELinux) or at least not penalize it.
Fine with me, feel free to ignore patches 4, 5 then.
> This was rejected last year.
It wasn't. The discussion did not come to a conclusion.
Best regards,
--
Kurt Garloff, Director SUSE Labs, Novell Inc.
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2005-02-14 23:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-13 21:05 [PATCH] 0/5: " Kurt Garloff
2005-02-13 21:10 ` [PATCH] 1/5: " Kurt Garloff
2005-02-13 21:11 ` [PATCH] 2/5: " Kurt Garloff
2005-02-13 21:11 ` [PATCH] 3/5: " Kurt Garloff
2005-02-13 21:12 ` [PATCH] 4/5: " Kurt Garloff
2005-02-13 21:12 ` [PATCH] 5/5: " Kurt Garloff
2005-02-14 16:50 ` James Morris
2005-02-14 23:23 ` Kurt Garloff [this message]
2005-02-14 16:54 ` [PATCH] 4/5: " Rik van Riel
2005-02-14 23:27 ` Kurt Garloff
2005-02-14 23:35 ` Rik van Riel
2005-02-14 14:30 ` [PATCH] 2/5: " Andreas Gruenbacher
2005-02-14 18:30 ` Kurt Garloff
2005-02-15 5:45 ` [PATCH] New " Kurt Garloff
2005-02-15 4:50 ` [PATCH] 0/5: " Chris Wright
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050214232325.GI18744@tpkurt.garloff.de \
--to=garloff@suse.de \
--cc=agruen@suse.de \
--cc=chrisw@osdl.org \
--cc=jmorris@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sds@epoch.ncsc.mil \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®