From: Alexey Dobriyan <adobriyan@mail.ru>
To: "Stephen C. Tweedie" <sct@redhat.com>
Cc: Andrew Morton <akpm@osdl.org>,
Andreas Dilger <adilger@clusterfs.com>,
ext3-users@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ext3: Fix sparse -Wbitwise warnings.
Date: Tue, 15 Feb 2005 20:13:21 +0200 [thread overview]
Message-ID: <200502152013.21556.adobriyan@mail.ru> (raw)
In-Reply-To: <1108476729.3363.9.camel@sisko.sctweedie.blueyonder.co.uk>
On Tuesday 15 February 2005 16:12, Stephen C. Tweedie wrote:
> On Tue, 2005-02-15 at 10:46, Alexey Dobriyan wrote:
>
> > - if ((ret = EXT3_HAS_RO_COMPAT_FEATURE(sb,
> > - ~EXT3_FEATURE_RO_COMPAT_SUPP))) {
> > + if ((ret = le32_to_cpu(EXT3_HAS_RO_COMPAT_FEATURE(sb,
> > + ~EXT3_FEATURE_RO_COMPAT_SUPP)))) {
>
> NAK.
Argh... stupid me. super.c part should be just:
--- linux-2.6.11-rc4/fs/ext3/super.c.orig 2005-02-15 20:01:52.000000000 +0200
+++ linux-2.6.11-rc4/fs/ext3/super.c 2005-02-15 20:02:47.000000000 +0200
@@ -2106,6 +2106,7 @@ static int ext3_remount (struct super_bl
ext3_mark_recovery_complete(sb, es);
} else {
__le32 ret;
+ int ret1;
if ((ret = EXT3_HAS_RO_COMPAT_FEATURE(sb,
~EXT3_FEATURE_RO_COMPAT_SUPP))) {
printk(KERN_WARNING "EXT3-fs: %s: couldn't "
@@ -2122,8 +2123,8 @@ static int ext3_remount (struct super_bl
*/
ext3_clear_journal_err(sb, es);
sbi->s_mount_state = le16_to_cpu(es->s_state);
- if ((ret = ext3_group_extend(sb, es, n_blocks_count)))
- return ret;
+ if ((ret1 = ext3_group_extend(sb, es, n_blocks_count)))
+ return ret1;
if (!ext3_setup_super (sb, es, 0))
sb->s_flags &= ~MS_RDONLY;
}
next prev parent reply other threads:[~2005-02-15 17:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-15 10:46 Alexey Dobriyan
2005-02-15 14:12 ` Stephen C. Tweedie
2005-02-15 18:13 ` Alexey Dobriyan [this message]
2005-02-15 23:29 ` Mitchell Blank Jr
2005-02-15 23:25 ` Stephen C. Tweedie
2005-02-15 23:46 ` Andreas Dilger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200502152013.21556.adobriyan@mail.ru \
--to=adobriyan@mail.ru \
--cc=adilger@clusterfs.com \
--cc=akpm@osdl.org \
--cc=ext3-users@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sct@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®