From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Peter Hagervall <hager@cs.umu.se>
Cc: linux-kernel@vger.kernel.org, torvalds@osdl.org
Subject: Re: [PATCH] Kill some sparse warnings
Date: Tue, 15 Feb 2005 22:56:56 +0000 [thread overview]
Message-ID: <20050215225655.A26733@flint.arm.linux.org.uk> (raw)
In-Reply-To: <20050215224553.GA24630@peppar.cs.umu.se>; from hager@cs.umu.se on Tue, Feb 15, 2005 at 11:45:53PM +0100
On Tue, Feb 15, 2005 at 11:45:53PM +0100, Peter Hagervall wrote:
> Cleaned up some address space issues in:
This is wrong, and highlights a problem with the "remote" dma pool API.
dma_alloc_coherent() normally returns CPU-local memory, unless you've
declared remote memory, in which case it's __iomem-type memory.
Therefore, I don't think we want to mark the return value of
dma_alloc_coherent with __iomem, because in the vast majority of
cases, it isn't.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 PCMCIA - http://pcmcia.arm.linux.org.uk/
2.6 Serial core
next prev parent reply other threads:[~2005-02-15 23:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-15 22:45 Peter Hagervall
2005-02-15 22:52 ` Linus Torvalds
2005-02-15 22:56 ` Russell King [this message]
2005-02-15 23:33 ` Peter Hagervall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050215225655.A26733@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=hager@cs.umu.se \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®