From: Ingo Molnar <mingo@elte.hu>
To: Mark Gross <mgross@linux.intel.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
LKML <linux-kernel@vger.kernel.org>,
"David S. Miller" <davem@redhat.com>,
Mark_H_Johnson@raytheon.com
Subject: Re: queue_work from interrupt Real time preemption2.6.11-rc2-RT-V0.7.37-03
Date: Wed, 16 Feb 2005 06:16:45 +0100 [thread overview]
Message-ID: <20050216051645.GB15197@elte.hu> (raw)
In-Reply-To: <200502151006.44809.mgross@linux.intel.com>
* Mark Gross <mgross@linux.intel.com> wrote:
> I'm attempting to change the softIRQ preemption implementation to use
> work queues (one per softIRQ), that allow for runtime priority changes
> on a per-soft IRQ bases. To do this I was trying to have
> raise_softirq call queu_work directly. queue_work, doesn't use the
> *_nort() api's.
>
> My alternitive is to put the call to queue_work into do_softIRQ.
> Which seems to work, but feels like a bit too much indirection to
> queue up the soft IRQ bottom half processing.
correct, that may be too much of an indirection.
we cannot turn queue_work()'s spinlocks into raw spinlocks, because that
would necessiate waitqueue locks to be raw spinlocks too, which would be
generally bad. Check out how entangled the cwq->work_done and
cwq->more_work waitqueues are with cwq->lock.
also, i'm not sure about how correctly this maps to the upstream softirq
semantics. Right now softirqs are processed by a single context (per
CPU), and each softirq type is processed serially. Softirqs are
preemptable, but they dont preempt each other. Maybe the networking
stack would break if we allowed the TIMER softirq (thread) to preempt
the NET softirq (threads) (and vice versa)?
but, prioritizing individual softirqs (within the PREEMPT_RT framework)
is something that needs to be thought about - e.g. Mark H. Johnson
reported various PREEMPT_RT (and softirq threading) SMP artifacts that
seem to be related to the current 'all softirqs are processed by a
single thread' approach. (check Mark's postings for 'ping' latency
anomalies)
Ingo
next prev parent reply other threads:[~2005-02-16 5:17 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-14 20:40 Mark Gross
2005-02-14 21:24 ` Steven Rostedt
2005-02-14 22:29 ` Mark Gross
2005-02-15 10:41 ` Ingo Molnar
2005-02-15 18:06 ` Mark Gross
2005-02-16 5:16 ` Ingo Molnar [this message]
2005-02-16 16:11 ` David S. Miller
2005-02-16 17:59 ` George Anzinger
2005-02-16 22:55 ` Mark Gross
2005-02-16 18:02 ` Steven Rostedt
2005-02-17 7:57 ` Ingo Molnar
2005-02-17 15:13 ` Steven Rostedt
2005-02-17 7:52 ` Ingo Molnar
2005-02-17 14:57 ` Steven Rostedt
2005-02-17 16:14 ` Mark Gross
2005-03-29 8:57 ` Ingo Molnar
2005-03-31 18:41 ` Mark Gross
2005-04-01 5:55 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050216051645.GB15197@elte.hu \
--to=mingo@elte.hu \
--cc=Mark_H_Johnson@raytheon.com \
--cc=davem@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgross@linux.intel.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®