From: Alexey Dobriyan <adobriyan@mail.ru>
To: Al Viro <viro@parcelfarce.linux.theplanet.co.uk>
Cc: linux-kernel@vger.kernel.org
Subject: "__be32 s_addr" ? (was Re: [PATCH] procfs: Fix sparse warnings)
Date: Wed, 16 Feb 2005 12:28:09 +0200 [thread overview]
Message-ID: <200502161228.09900.adobriyan@mail.ru> (raw)
In-Reply-To: <20050216083550.GO8859@parcelfarce.linux.theplanet.co.uk>
On Wednesday 16 February 2005 10:35, Al Viro wrote:
> Most of the mess is in drivers/*, arch/* and (for endianness patches) net/*...
Yes, net/*. Many do X.s_addr = htonl(blah). Is this correct?
--- a/include/linux/in.h
+++ b/include/linux/in.h
@@ -51,7 +51,7 @@ enum {
/* Internet address. */
struct in_addr {
- __u32 s_addr;
+ __be32 s_addr;
};
#define IP_TOS 1
It gives approximately "486 insertions(+), 183 deletions(-)" between two
logs without and with this change (adds more then removes as is).
Alexey
prev parent reply other threads:[~2005-02-16 9:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-15 12:55 [PATCH] procfs: Fix sparse warnings Alexey Dobriyan
2005-02-15 11:59 ` Al Viro
2005-02-15 13:12 ` Alexey Dobriyan
2005-02-15 19:26 ` Al Viro
2005-02-16 8:35 ` Al Viro
2005-02-16 10:28 ` Alexey Dobriyan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200502161228.09900.adobriyan@mail.ru \
--to=adobriyan@mail.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@parcelfarce.linux.theplanet.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®