From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261496AbVBRUlg (ORCPT ); Fri, 18 Feb 2005 15:41:36 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261484AbVBRUlf (ORCPT ); Fri, 18 Feb 2005 15:41:35 -0500 Received: from fire.osdl.org ([65.172.181.4]:15013 "EHLO smtp.osdl.org") by vger.kernel.org with ESMTP id S261482AbVBRUlV (ORCPT ); Fri, 18 Feb 2005 15:41:21 -0500 Date: Fri, 18 Feb 2005 12:41:04 -0800 From: Andrew Morton To: Kay Sievers Cc: linux-kernel@vger.kernel.org, greg@kroah.com, david@fubar.dk Subject: Re: [PATCH] add I/O error uevent for block devices Message-Id: <20050218124104.7e141bef.akpm@osdl.org> In-Reply-To: <20050218201713.GA9084@vrfy.org> References: <20050218083316.GA6619@vrfy.org> <20050218014621.0b453232.akpm@osdl.org> <20050218124503.GA7705@vrfy.org> <20050218110232.6512f0fb.akpm@osdl.org> <20050218201713.GA9084@vrfy.org> X-Mailer: Sylpheed version 0.9.7 (GTK+ 1.2.10; i386-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Kay Sievers wrote: > > On Fri, Feb 18, 2005 at 11:02:32AM -0800, Andrew Morton wrote: > > Kay Sievers wrote: > > > > > > > - there are numerous other places where an I/O error can be detected: > > > > grep the tree for b_end_io and bio_end_io. > > > > > > You mean the mmap and direct-io stuff? > > > > direct-io, certainly. Also reiserfs, xfs, ntfs, ext3, jfs and possibly md > > have their own I/O completion handlers. > > Hmm, ok. Any idea how to propagate errors like this in a saner way? Some of > these places don't even log errors and spreading uevents all over the place > doesn't sounds like the best idea. > I guess you should add some new generic function handle_block_io_error(bdev, rw, sector) in ll_rw_blk.c and do whatever you need to do inside that. Move the ratelimited printk there, too.