From: Al Viro <viro@parcelfarce.linux.theplanet.co.uk>
To: Robert Love <rml@novell.com>
Cc: Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org,
John McCutchan <ttb@tentacle.dhs.org>
Subject: Re: [patch] inotify for 2.6.11-rc3-mm2
Date: Fri, 18 Feb 2005 17:24:19 +0000 [thread overview]
Message-ID: <20050218172419.GP8859@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <1108744859.4667.7.camel@betsy.boston.ximian.com>
On Fri, Feb 18, 2005 at 11:40:59AM -0500, Robert Love wrote:
> inotify, bitches
/me does "pick a random function, find a race" again.
> +/*
> + * inode_add_watch - add a watch to the given inode
> + *
> + * Callers must hold dev->lock, because we call inode_find_dev().
> + */
> +static int inode_add_watch(struct inode *inode, struct inotify_watch *watch)
[snip]
> + list_add(&watch->i_list, &inode->inotify_data->watches);
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
... and that is protected by what?
> +
> + return 0;
Fix the damn locking, already.
next prev parent reply other threads:[~2005-02-18 17:24 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-10 10:35 2.6.11-rc3-mm2 Andrew Morton
2005-02-10 13:35 ` 2.6.11-rc3-mm2 Christoph Hellwig
2005-02-10 20:01 ` 2.6.11-rc3-mm2 Andrew Morton
2005-02-12 22:43 ` 2.6.11-rc3-mm2 Olaf Dietsche
2005-02-10 18:47 ` [patch] inotify for 2.6.11-rc3-mm2 Robert Love
2005-02-18 16:40 ` Robert Love
2005-02-18 17:24 ` Al Viro [this message]
2005-02-18 17:48 ` Robert Love
2005-02-10 19:20 ` [2.6.11-rc3-mm2 patch] mxser.c: remove unused variable Adrian Bunk
2005-02-10 22:13 ` 2.6.11-rc3-mm2 Corey Minyard
2005-02-10 22:42 ` 2.6.11-rc3-mm2 Benjamin Herrenschmidt
2005-02-10 23:02 ` 2.6.11-rc3-mm2 Andrew Morton
2005-02-10 23:31 ` 2.6.11-rc3-mm2 Benjamin Herrenschmidt
2005-02-10 23:17 ` 2.6.11-rc3-mm2 Adrian Bunk
2005-02-11 6:14 ` 2.6.11-rc3-mm2 (compile stats) John Cherry
2005-02-11 16:29 ` 2.6.11-rc3-mm2 Yuval Tanny
2005-02-12 14:53 ` 2.6.11-rc3-mm2 Henning Rohde
2005-02-14 13:22 ` 2.6.11-rc3-mm2 Stefano Rivoir
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050218172419.GP8859@parcelfarce.linux.theplanet.co.uk \
--to=viro@parcelfarce.linux.theplanet.co.uk \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rml@novell.com \
--cc=ttb@tentacle.dhs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome