mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: Guillaume Thouvenin <guillaume.thouvenin@bull.net>
Cc: linux-kernel@vger.kernel.org, johnpol@2ka.mipt.ru,
	elsa-devel@lists.sourceforge.net, jlan@engr.sgi.com,
	gh@us.ibm.com, efocht@hpce.nec.com
Subject: Re: [PATCH 2.6.11-rc4-mm1] connector: Add a fork connector
Date: Thu, 24 Feb 2005 02:46:05 -0800	[thread overview]
Message-ID: <20050224024605.76e7369f.akpm@osdl.org> (raw)
In-Reply-To: <1109240677.1738.196.camel@frecb000711.frec.bull.fr>

Guillaume Thouvenin <guillaume.thouvenin@bull.net> wrote:
>
>  +#define CN_FORK_MSG_SIZE 	sizeof(struct cn_msg) + CN_FORK_INFO_SIZE

This really should be parenthesized.

>  +spinlock_t fork_cn_lock = SPIN_LOCK_UNLOCKED;

This should have static scope, and could be local to fork_connector().

Please use DEFINE_SPINLOCK().  (There's a reason for this, but I forget
what it was).

>  +static inline void fork_connector(pid_t parent, pid_t child)
>  +{
>  +	static const struct cb_id fork_id = { CN_IDX_FORK, CN_VAL_FORK };

It's a bit lame to have two copies of this.  Maybe have just a single copy,
declare it in connector.h?


  parent reply	other threads:[~2005-02-24 10:47 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-02-24 10:24 Guillaume Thouvenin
2005-02-24 10:45 ` Evgeniy Polyakov
2005-02-24 12:05   ` Guillaume Thouvenin
2005-02-24 10:46 ` Andrew Morton [this message]
2005-02-24 15:47   ` Ryan Anderson
2005-02-25 16:54 ` aq
2005-02-25 17:19   ` Tim Schmielau
2005-02-25 18:13   ` Chris Wright
2005-03-02  8:48 ` Guillaume Thouvenin
2005-03-02 14:51   ` Paul Jackson
2005-03-02 17:48     ` Jesse Barnes
2005-03-02 15:50   ` Paul Jackson
2005-03-03  3:18   ` Kaigai Kohei
2005-03-03  5:46     ` Evgeniy Polyakov
2005-03-03 11:51       ` Evgeniy Polyakov
2005-03-03 12:20         ` Evgeniy Polyakov
2005-03-08  7:29 ` Guillaume Thouvenin
2005-03-08  8:45   ` Guillaume Thouvenin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050224024605.76e7369f.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=efocht@hpce.nec.com \
    --cc=elsa-devel@lists.sourceforge.net \
    --cc=gh@us.ibm.com \
    --cc=guillaume.thouvenin@bull.net \
    --cc=jlan@engr.sgi.com \
    --cc=johnpol@2ka.mipt.ru \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®