From: Albert Herranz <albert_herranz@yahoo.es>
To: "Eric W. Biederman" <ebiederm@xmission.com>,
Andrew Morton <akpm@osdl.org>
Cc: fastboot@lists.osdl.org, linux-kernel@vger.kernel.org
Subject: [PATCH 2.6.11-rc4-mm1] kexec: ppc: fix NORET_TYPE
Date: Thu, 24 Feb 2005 21:41:19 +0100 (CET) [thread overview]
Message-ID: <20050224204119.90365.qmail@web52310.mail.yahoo.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 411 bytes --]
Hi,
On ppc machine_kexec.c, we must apply NORET_TYPE to
machine_kexec() as it does not return, and make it
noreturn (otherwise compiler complains).
NORET_TYPE is in fact not needed for
machine_kexec_simple().
Signed-off-by: Albert Herranz
Cheers,
Albert
______________________________________________
Renovamos el Correo Yahoo!: ¡250 MB GRATIS!
Nuevos servicios, más seguridad
http://correo.yahoo.es
[-- Attachment #2: kexec-ppc-NORET_TYPE-fix.patch --]
[-- Type: text/plain, Size: 960 bytes --]
--- a/arch/ppc/kernel/machine_kexec.c 2005-02-24 20:00:14.000000000 +0100
+++ b/arch/ppc/kernel/machine_kexec.c 2005-02-24 21:55:51.000000000 +0100
@@ -69,7 +69,7 @@ void machine_kexec_cleanup(struct kimage
* Do not allocate memory (or fail in any way) in machine_kexec().
* We are past the point of no return, committed to rebooting now.
*/
-void machine_kexec(struct kimage *image)
+NORET_TYPE void machine_kexec(struct kimage *image)
{
if (ppc_md.machine_kexec) {
ppc_md.machine_kexec(image);
@@ -80,6 +80,7 @@ void machine_kexec(struct kimage *image)
*/
machine_restart(NULL);
}
+ for(;;);
}
@@ -90,7 +91,7 @@ void machine_kexec(struct kimage *image)
* jumps to it.
* A platform specific function may just call this one.
*/
-NORET_TYPE void machine_kexec_simple(struct kimage *image)
+void machine_kexec_simple(struct kimage *image)
{
unsigned long page_list;
unsigned long reboot_code_buffer, reboot_code_buffer_phys;
reply other threads:[~2005-02-24 20:42 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050224204119.90365.qmail@web52310.mail.yahoo.com \
--to=albert_herranz@yahoo.es \
--cc=akpm@osdl.org \
--cc=ebiederm@xmission.com \
--cc=fastboot@lists.osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®