mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Corey Minyard <minyard@acm.org>
Cc: Andrew Morton <akpm@osdl.org>, lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] I2C patch 2 - break up the SMBus formatting
Date: Fri, 25 Feb 2005 13:41:54 -0800	[thread overview]
Message-ID: <20050225214154.GB27270@kroah.com> (raw)
In-Reply-To: <421E62DD.5030608@acm.org>

On Thu, Feb 24, 2005 at 05:27:25PM -0600, Corey Minyard wrote:
> This is one in a series of patches for adding a non-blocking interface 
> to the I2C driver for supporting the IPMI SMBus driver.

> This patch reorganizes the formatting code to  make it more
> suitable for the upcoming non-blocking changes.  It also adds
> an op queue entry that is used to pass data around (for now)
> and will be used for queueing in the non-blocking case.

Hm, ick.  Can you break this up into 2 pieces?  One that reorders the
formatting of the code, and then one that adds the new functionality?
Otherwise it's very hard to follow the changes that are happening in
here.

thanks,

greg k-h

  reply	other threads:[~2005-02-25 21:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-02-24 23:27 Corey Minyard
2005-02-25 21:41 ` Greg KH [this message]
2005-02-25 21:44 ` Greg KH
2005-02-25 22:46   ` Corey Minyard
2005-02-25 23:00     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050225214154.GB27270@kroah.com \
    --to=greg@kroah.com \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=minyard@acm.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®