From: Andrew Morton <akpm@osdl.org>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: zwane@arm.linux.org.uk, linuxppc64-dev@ozlabs.org,
linux-kernel@vger.kernel.org, nathanl@austin.ibm.com
Subject: Re: [PATCH] PPC64: Generic hotplug cpu support
Date: Sun, 27 Feb 2005 14:49:28 -0800 [thread overview]
Message-ID: <20050227144928.6c71adaf.akpm@osdl.org> (raw)
In-Reply-To: <1109542971.14993.217.camel@gaston>
Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
>
> > - if (cpu_is_offline(smp_processor_id()) &&
> > + if (cpu_is_offline(_smp_processor_id()) &&
> > system_state == SYSTEM_RUNNING)
> > cpu_die();
> > }
> > _
>
> This is the idle loop. Is that ever supposed to be preempted ?
Nope, it's a false positive. We had to do the same in x86's idle loop and
probably others will hit it.
next prev parent reply other threads:[~2005-02-27 22:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-01 18:25 Zwane Mwaikambo
2005-02-27 11:16 ` Andrew Morton
2005-02-27 22:22 ` Benjamin Herrenschmidt
2005-02-27 22:49 ` Andrew Morton [this message]
2005-03-02 1:47 ` [PATCH] explicitly bind idle tasks Nathan Lynch
2005-03-02 3:13 ` Zwane Mwaikambo
2005-03-07 23:01 ` Joel Schopp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050227144928.6c71adaf.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc64-dev@ozlabs.org \
--cc=nathanl@austin.ibm.com \
--cc=zwane@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®