mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bartlomiej Zolnierkiewicz <bzolnier@elka.pw.edu.pl>
To: Tejun Heo <htejun@gmail.com>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [patch ide-dev 7/9] convert disk flush functions to use REQ_DRIVE_TASKFILE
Date: Sun, 27 Feb 2005 17:39:16 +0100	[thread overview]
Message-ID: <200502271739.16076.bzolnier@elka.pw.edu.pl> (raw)
In-Reply-To: <20050227045125.GA25723@htj.dyndns.org>


On Sunday 27 February 2005 05:51, Tejun Heo wrote:
>  Hello, Bartlomiej,
> 
> On Thu, Feb 24, 2005 at 03:45:39PM +0100, Bartlomiej Zolnierkiewicz wrote:
> > 
> > Original patch from Tejun Heo <htejun@gmail.com>,
> > ported over recent IDE changes by me.
> > 
> > * teach ide_tf_get_address() about CHS
> 
>  IMHO, as patch #4 moves LBA/CHS selection into taskfile, I think
> using taskfile->device to determine whether LBA or CHS is used instead
> of drive->select makes more sense.
>
> > * use ide_tf_get_address() and remove ide_get_error_location()
> 
>  IIRC, error responses for WIN_FLUSH_CACHE is in CHS if the LBA bit in
> the device register is zero; likewise, in LBA if the LBA bit is one.
> I don't know if drives can change the LBA bit when posting error
> result.  The original code reads back the device register on error to
> determine whether to interpret the error response in CHS or LBA.
> (ATA/ATAPI-6 isn't clear on this issue.  Is ATA/ATAPI-7 updated?)

The thing is that LBA bit is marked as "na" for FLUSH CACHE
in all ATA/ATAPI drafts that I've seen.

>  This change combined with patch #2/#5 can make error address
> calculation wrong on LBA28 drives.  I think setting the LBA bit in the
> device register according to the drive's addressing mode in
> ide_task_init_flush() and use taskfile->device in ide_tf_get_address()
> should fix the problem.

I will change the code to set LBA bit, it shouldn't hurt. :-)

  reply	other threads:[~2005-02-28 13:36 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-02-24 14:45 Bartlomiej Zolnierkiewicz
2005-02-27  4:51 ` Tejun Heo
2005-02-27 16:39   ` Bartlomiej Zolnierkiewicz [this message]
2005-02-28 15:12     ` Tejun Heo
2005-02-28 16:17       ` Bartlomiej Zolnierkiewicz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200502271739.16076.bzolnier@elka.pw.edu.pl \
    --to=bzolnier@elka.pw.edu.pl \
    --cc=htejun@gmail.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®