From: Christoph Hellwig <hch@infradead.org>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: Wen Xiong <wendyx@us.ibm.com>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
Andrew Morton <akpm@osdl.org>, Greg KH <greg@kroah.com>
Subject: Re: [ patch 6/7] drivers/serial/jsm: new serial device driver
Date: Mon, 28 Feb 2005 03:22:20 +0000 [thread overview]
Message-ID: <20050228032220.GB5300@infradead.org> (raw)
In-Reply-To: <42226A3E.6000707@pobox.com>
On Sun, Feb 27, 2005 at 07:47:58PM -0500, Jeff Garzik wrote:
> >+struct shrink_buf_struct {
> >+ unsigned int shrink_buf_vaddr; /* Virtual address of board
> >*/
> >+ unsigned int shrink_buf_phys; /* Physical address of board
> >*/
>
> Major bug. These should be unsigned long.
not sure what they actually mean, but a virtual address should be
a void * and drivers shouldn't ever mess with physical addresses.
next prev parent reply other threads:[~2005-02-28 3:22 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-27 23:40 Wen Xiong
2005-02-28 0:47 ` Jeff Garzik
2005-02-28 3:22 ` Christoph Hellwig [this message]
2005-02-28 0:56 ` Rik van Riel
2005-02-28 1:45 ` Nish Aravamudan
2005-02-28 6:55 ` Greg KH
2005-03-04 21:08 ` Wen Xiong
2005-03-05 6:44 ` Greg KH
2005-03-07 22:48 ` Wen Xiong
2005-03-08 6:42 ` Greg KH
2005-03-08 18:42 ` Wen Xiong
2005-03-09 6:04 ` Greg KH
2005-03-09 15:50 ` Wen Xiong
2005-03-09 16:31 ` Greg KH
2005-03-09 17:31 ` Wen Xiong
2005-03-09 17:42 Kilau, Scott
2005-03-09 19:12 ` Greg KH
2005-03-09 22:11 ` Wen Xiong
2005-03-09 19:35 Kilau, Scott
2005-03-09 19:51 ` Greg KH
2005-03-09 20:33 ` Wen Xiong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050228032220.GB5300@infradead.org \
--to=hch@infradead.org \
--cc=akpm@osdl.org \
--cc=greg@kroah.com \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=wendyx@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®