From: Stelian Pop <stelian@popies.net>
To: "emmanuel.colbus@ensimag.imag.fr" <colbuse@ensisun.imag.fr>
Cc: linux-kernel@vger.kernel.org, arjan@infradead.org
Subject: Re: [patch 3/2] drivers/char/vt.c: remove unnecessary code
Date: Mon, 28 Feb 2005 20:18:56 +0100 [thread overview]
Message-ID: <20050228191855.GC17559@sd291.sivit.org> (raw)
In-Reply-To: <Pine.GSO.4.40.0502281817001.27182-100000@ensisun>
On Mon, Feb 28, 2005 at 06:29:39PM +0100, emmanuel.colbus@ensimag.imag.fr wrote:
> Well, without it, it gives :
>
>
>
> --- old/drivers/char/vt.c 2004-12-24 22:35:25.000000000 +0100
> +++ new/drivers/char/vt.c 2005-02-28 18:19:11.782717810 +0100
> @@ -1655,8 +1655,8 @@
> vc_state = ESnormal;
> return;
> case ESsquare:
> - for(npar = 0 ; npar < NPAR ; npar++)
> - par[npar] = 0;
> + memset(par, 0, NPAR*sizeof(unsigned int));
> npar = 0;
> vc_state = ESgetpars;
> if (c == '[') { /* Function key */
>
>
>
>
> Any other comments/remarks, or is _this_ patch version acceptable?
A not whitespace-mangled version of it could be.
Stelian.
--
Stelian Pop <stelian@popies.net>
next prev parent reply other threads:[~2005-02-28 19:19 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-28 15:06 colbuse
2005-02-28 16:44 ` Stelian Pop
2005-02-28 17:29 ` emmanuel.colbus@ensimag.imag.fr
2005-02-28 19:18 ` Stelian Pop [this message]
2005-02-28 20:30 ` Adrian Bunk
-- strict thread matches above, loose matches on Subject: below --
2005-02-28 13:13 colbuse
2005-02-28 13:28 ` Russell King
2005-02-28 14:01 ` colbuse
2005-02-28 14:22 ` Arjan van de Ven
2005-02-28 14:43 ` Martin Mares
2005-02-28 14:57 ` Horst von Brand
2005-02-28 13:32 ` Adrian Bunk
2005-02-28 13:48 ` Dmitry Torokhov
2005-02-28 14:02 ` Arjan van de Ven
2005-02-28 14:06 ` Dmitry Torokhov
2005-02-28 12:57 colbuse
2005-02-28 13:02 ` Russell King
2005-02-28 13:33 ` linux-os
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050228191855.GC17559@sd291.sivit.org \
--to=stelian@popies.net \
--cc=arjan@infradead.org \
--cc=colbuse@ensisun.imag.fr \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®