From: Andrew Morton <akpm@osdl.org>
To: Vivek Goyal <vgoyal@in.ibm.com>
Cc: ebiederm@xmission.com, fastboot@lists.osdl.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC][PATCH 3/3] Kdump: Export crash notes section address through sysfs
Date: Mon, 28 Feb 2005 22:05:02 -0800 [thread overview]
Message-ID: <20050228220502.177f75a1.akpm@osdl.org> (raw)
In-Reply-To: <1109261865.5148.819.camel@terminator.in.ibm.com>
Vivek Goyal <vgoyal@in.ibm.com> wrote:
>
> o Following patch exports kexec global variable "crash_notes" to user space
> through sysfs as kernel attribute in /sys/kernel.
It breaks the x86_64 build. A fix for that is below.
Please test kexec/kdump patches on all three architectures, both with your
config option enabled and with it disabled. There are cross-compilers at
http://developer.osdl.org/dev/plm/cross_compile/
It also breaks the ppc build:
kernel/ksysfs.c: In function `crash_notes_show':
kernel/ksysfs.c:38: error: `crash_notes' undeclared (first use in this function)
kernel/ksysfs.c:38: error: (Each undeclared identifier is reported only once
kernel/ksysfs.c:38: error: for each function it appears in.)
but as ppc doesn't support crashdump, that is unfixable.
Why is the crashdump feature linked to CONFIG_KEXEC? It should have its
own config option, which is dependent upon kexec.
kernel/ksysfs.c: In function `crash_notes_show':
kernel/ksysfs.c:38: error: `crash_notes' undeclared (first use in this function)
kernel/ksysfs.c:38: error: (Each undeclared identifier is reported only once
kernel/ksysfs.c:38: error: for each function it appears in.)
Signed-off-by: Andrew Morton <akpm@osdl.org>
---
25-akpm/arch/x86_64/kernel/crash.c | 3 ---
25-akpm/include/asm-x86_64/kexec.h | 5 +++++
2 files changed, 5 insertions(+), 3 deletions(-)
diff -puN include/asm-x86_64/kexec.h~kdump-export-crash-notes-section-address-through-x86_64-fix include/asm-x86_64/kexec.h
--- 25/include/asm-x86_64/kexec.h~kdump-export-crash-notes-section-address-through-x86_64-fix 2005-02-28 21:54:41.000000000 -0800
+++ 25-akpm/include/asm-x86_64/kexec.h 2005-02-28 21:55:12.000000000 -0800
@@ -25,4 +25,9 @@
/* The native architecture */
#define KEXEC_ARCH KEXEC_ARCH_X86_64
+#define MAX_NOTE_BYTES 1024
+typedef u32 note_buf_t[MAX_NOTE_BYTES/4];
+
+extern note_buf_t crash_notes[];
+
#endif /* _X86_64_KEXEC_H */
diff -puN arch/x86_64/kernel/crash.c~kdump-export-crash-notes-section-address-through-x86_64-fix arch/x86_64/kernel/crash.c
--- 25/arch/x86_64/kernel/crash.c~kdump-export-crash-notes-section-address-through-x86_64-fix 2005-02-28 21:58:39.000000000 -0800
+++ 25-akpm/arch/x86_64/kernel/crash.c 2005-02-28 21:58:55.000000000 -0800
@@ -22,9 +22,6 @@
#include <asm/nmi.h>
#include <asm/hw_irq.h>
-#define MAX_NOTE_BYTES 1024
-typedef u32 note_buf_t[MAX_NOTE_BYTES/4];
-
note_buf_t crash_notes[NR_CPUS];
void machine_crash_shutdown(void)
_
next prev parent reply other threads:[~2005-03-01 6:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-24 16:17 Vivek Goyal
2005-03-01 6:05 ` Andrew Morton [this message]
2005-03-01 22:03 ` [Fastboot] " Randy.Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050228220502.177f75a1.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=ebiederm@xmission.com \
--cc=fastboot@lists.osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vgoyal@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®