From: Greg KH <greg@kroah.com>
To: benh@kernel.crashing.org
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] fix module paramater permissions in radeon_base.c
Date: Tue, 1 Mar 2005 23:11:47 -0800 [thread overview]
Message-ID: <20050302071147.GA29444@kroah.com> (raw)
You really don't want -2 for the file mode in sysfs. It creates:
-rwsrwsrwT 1 root root 4096 Mar 1 22:59 /sys/module/radeonfb/parameters/default_dynclk
on my box. Here's a fix against a clean 2.6.11-rc5 kernel, please
forward onward as you see fit.
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
--- 1.27/drivers/video/aty/radeon_base.c 2005-02-24 11:40:00 -08:00
+++ edited/drivers/video/aty/radeon_base.c 2005-03-01 23:09:12 -08:00
@@ -2551,7 +2551,7 @@
MODULE_DESCRIPTION("framebuffer driver for ATI Radeon chipset");
MODULE_LICENSE("GPL");
module_param(noaccel, bool, 0);
-module_param(default_dynclk, int, -2);
+module_param(default_dynclk, int, 0);
MODULE_PARM_DESC(default_dynclk, "int: -2=enable on mobility only,-1=do not change,0=off,1=on");
MODULE_PARM_DESC(noaccel, "bool: disable acceleration");
module_param(nomodeset, bool, 0);
next reply other threads:[~2005-03-02 7:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-02 7:11 Greg KH [this message]
2005-03-02 7:14 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050302071147.GA29444@kroah.com \
--to=greg@kroah.com \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome