mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: James Chapman <jchapman@katalix.com>
Cc: sensors@stimpy.netroedge.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH: 2.6.11-rc5] i2c chips: ds1337 RTC driver
Date: Wed, 2 Mar 2005 21:04:04 -0800	[thread overview]
Message-ID: <20050302210404.2749aed5.akpm@osdl.org> (raw)
In-Reply-To: <42235171.80500@katalix.com>

James Chapman <jchapman@katalix.com> wrote:
>
> Add DS1337 RTC chip driver.
> 

drivers/i2c/chips/ds1337.c:60: `I2C_DRIVERID_DS1337' undeclared here (not in a function)


Also, there are changes in Greg's i2c tree which break your new driver:

drivers/i2c/chips/ds1337.c:60: initializer element is not constant
drivers/i2c/chips/ds1337.c:60: (near initialization for `ds1337_driver.id')
drivers/i2c/chips/ds1337.c: In function `ds1337_get_datetime':
drivers/i2c/chips/ds1337.c:155: structure has no member named `id'
drivers/i2c/chips/ds1337.c: In function `ds1337_set_datetime':
drivers/i2c/chips/ds1337.c:206: structure has no member named `id'
drivers/i2c/chips/ds1337.c: In function `ds1337_detect':
drivers/i2c/chips/ds1337.c:333: structure has no member named `id'
drivers/i2c/chips/ds1337.c:343: structure has no member named `id'


      parent reply	other threads:[~2005-03-03  5:13 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-02-28 17:14 James Chapman
2005-03-01  7:54 ` Greg KH
2005-03-01 19:21   ` James Chapman
2005-03-02  9:43     ` Jean Delvare
2005-03-02 18:45       ` [PATCH 2.6] Trivial indentation fix in i2c/chips/Kconfig Jean Delvare
2005-03-03  0:14         ` Greg KH
2005-03-03 17:23       ` [PATCH: 2.6.11-rc5] i2c chips: ds1337 RTC driver James Chapman
2005-03-03 19:49         ` Jean Delvare
2005-03-04  0:08           ` James Chapman
2005-03-04  8:45             ` Jean Delvare
2005-03-02 16:59     ` Greg KH
2005-03-03  5:04 ` Andrew Morton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050302210404.2749aed5.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=jchapman@katalix.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sensors@stimpy.netroedge.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome