mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "George G. Davis" <gdavis@mvista.com>
To: sam@ravnborg.org, linux-kernel@vger.kernel.org
Subject: [PATCH] Fix scripts/mkuboot.sh to return status
Date: Thu, 3 Mar 2005 16:16:41 -0500	[thread overview]
Message-ID: <20050303211640.GB20870@mvista.com> (raw)

Sam,

If `mkimage` is either not found in search path or returns non-zero status,
`make uImage` succeeds when it should fail. This changes scripts/mkuboot.sh
to return status so build succeeds or fails as appropriate.

Source: MontaVista Software, Inc.
MR: 10761
Type: Defect Fix
Disposition: submitted to linux-kernel@vger.kernel.org
Keywords:
Description:
Fix scripts/mkuboot.sh to return non-zero status to indicate
build failure when uImage target is not created.

Signed-off-by: George G. Davis <gdavis@mvista.com>

Index: linux-2.6.11-bk/scripts/mkuboot.sh
===================================================================
--- linux-2.6.11-bk.orig/scripts/mkuboot.sh
+++ linux-2.6.11-bk/scripts/mkuboot.sh
@@ -9,8 +9,10 @@
 if [ -z "${MKIMAGE}" ]; then
 	# Doesn't exist
 	echo '"mkimage" command not found - U-Boot images will not be built' >&2
-	exit 0;
+	exit -1
 fi
 
 # Call "mkimage" to create U-Boot image
 ${MKIMAGE} "$@"
+
+exit $?

--
Regards,
George

             reply	other threads:[~2005-03-03 21:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-03-03 21:16 George G. Davis [this message]
2005-03-13  8:57 ` Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050303211640.GB20870@mvista.com \
    --to=gdavis@mvista.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sam@ravnborg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®