From: Andrew Morton <akpm@osdl.org>
To: gene.heskett@verizon.net, linux-kernel@vger.kernel.org,
kraxel@bytesex.org
Subject: Re: 2.6.11 vs DVB cx88 stuffs
Date: Thu, 3 Mar 2005 23:17:16 -0800 [thread overview]
Message-ID: <20050303231716.14a48f5f.akpm@osdl.org> (raw)
In-Reply-To: <20050303224438.2952f63e.akpm@osdl.org>
Andrew Morton <akpm@osdl.org> wrote:
>
> >
> > I've a new pcHDTV-3000 card, and I thought maybe it would
> > be a good idea to build the cx88 stuff in the DVB section
> > of a make xconfig.
> >
> > It doesn't build, spitting out this bailout:
> >
> > CC [M] drivers/media/video/cx88/cx88-cards.o
> > drivers/media/video/cx88/cx88-cards.c: In function `hauppauge_eeprom_dvb':
> > drivers/media/video/cx88/cx88-cards.c:694: error: `PLLTYPE_DTT7595' undeclared (first use in this function)
> > drivers/media/video/cx88/cx88-cards.c:694: error: (Each undeclared identifier is reported only once
> > drivers/media/video/cx88/cx88-cards.c:694: error: for each function it appears in.)
> > drivers/media/video/cx88/cx88-cards.c:698: error: `PLLTYPE_DTT7592' undeclared (first use in this function)
> > drivers/media/video/cx88/cx88-cards.c: In function `cx88_card_setup':
> > drivers/media/video/cx88/cx88-cards.c:856: error: `PLLTYPE_DTT7579' undeclared (first use in this function)
>
> OK, this is one for Gerd. Those identifiers just aren't anywhere in the tree.
>
<googles>
OK, the below should get you going again. It fixes up a warning too.
> The reason this wasn't picked up is that neither `make allyesconfig' or
> `make allmodconfig' enables CONFIG_VIDEO_CX88_DVB or
> CONFIG_VIDEO_CX88_DVB_MODULE.
>
> For coverage purposes it would be excellent to fix that up too, please.
Wise words, those.
diff -puN drivers/media/dvb/frontends/cx22702.h~c8xx-cards-build-fix drivers/media/dvb/frontends/cx22702.h
--- 25/drivers/media/dvb/frontends/cx22702.h~c8xx-cards-build-fix 2005-03-03 23:13:59.000000000 -0800
+++ 25-akpm/drivers/media/dvb/frontends/cx22702.h 2005-03-03 23:14:17.000000000 -0800
@@ -30,6 +30,10 @@
#include <linux/dvb/frontend.h>
+#define PLLTYPE_DTT7592 1
+#define PLLTYPE_DTT7595 2
+#define PLLTYPE_DTT7579 3
+
struct cx22702_config
{
/* the demodulator's i2c address */
diff -puN drivers/media/video/cx88/cx88-cards.c~c8xx-cards-build-fix drivers/media/video/cx88/cx88-cards.c
--- 25/drivers/media/video/cx88/cx88-cards.c~c8xx-cards-build-fix 2005-03-03 23:15:09.000000000 -0800
+++ 25-akpm/drivers/media/video/cx88/cx88-cards.c 2005-03-03 23:15:35.000000000 -0800
@@ -707,6 +707,7 @@ static int hauppauge_eeprom_dvb(struct c
core->pll_addr = 0x61;
core->demod_addr = 0x43;
+ return 0;
}
#endif
_
next prev parent reply other threads:[~2005-03-04 7:22 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-04 2:19 Gene Heskett
2005-03-04 2:45 ` Andrew Morton
2005-03-04 3:50 ` Russell Miller
2005-03-04 4:01 ` Gene Heskett
2005-03-04 2:55 ` Randy.Dunlap
2005-03-04 4:07 ` Gene Heskett
2005-03-04 4:45 ` Gene Heskett
2005-03-04 12:24 ` [linux-dvb-maintainer] " Johannes Stezenbach
2005-03-04 15:02 ` Gene Heskett
2005-03-04 6:44 ` Andrew Morton
2005-03-04 7:17 ` Andrew Morton [this message]
2005-03-04 7:39 ` Dave Jones
2005-03-04 8:51 ` Gerd Knorr
2005-03-04 9:03 ` Gene Heskett
2005-03-04 7:23 ` Nish Aravamudan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050303231716.14a48f5f.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=gene.heskett@verizon.net \
--cc=kraxel@bytesex.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®