From: Nishanth Aravamudan <nacc@us.ibm.com>
To: kj <kernel-janitors@lists.osdl.org>, lkml <linux-kernel@vger.kernel.org>
Subject: [UPDATE PATCH] cdrom/mcdx: fix wait-queue compile-time breakage
Date: Thu, 3 Mar 2005 16:25:39 -0800 [thread overview]
Message-ID: <20050304002539.GE16078@us.ibm.com> (raw)
In-Reply-To: <20050302095710.GA3745@nd47.coderock.org>
On Wed, Mar 02, 2005 at 10:57:10AM +0100, Domen Puncer wrote:
> A new release from kernel janitors (http://janitor.kernelnewbies.org/).
>
> Apologies to janitors that this took so long.
> This time we have a new record: 354 patches!
> I'll start sending/resending what's not already in -mm soon.
>
> Patchset is at http://coderock.org/kj/2.6.11-kj/
<snip>
> int_sleep_on-drivers_cdrom_mcdx.patch
> From: Nishanth Aravamudan <nacc@us.ibm.com>
> Subject: [KJ] [PATCH 16/20] cdrom/mcdx: remove interruptible_sleep_on_timeout() usage
Description: The original patch leads to compile-warnings from older
version of GCC and violates CodingStyle. Moving the declaration to the
head of the function fixes it.
--- 2.6.11-kj-v/drivers/cdrom/mcdx.c 2005-03-02 11:21:41.000000000 -0800
+++ 2.6.11-kj/drivers/cdrom/mcdx.c 2005-03-03 10:30:32.000000000 -0800
@@ -838,10 +838,10 @@ static void mcdx_delay(struct s_drive_st
* May be we could use a simple count loop w/ jumps to itself, but
* I wanna make this independent of cpu speed. [1 jiffy is 1/HZ] sec */
{
+ DEFINE_WAIT(wait);
if (jifs < 0)
return;
- DEFINE_WAIT(wait);
xtrace(SLEEP, "*** delay: sleepq\n");
prepare_to_wait(&stuff->sleepq, &wait, TASK_INTERRUPTIBLE);
schedule_timeout(jifs);
prev parent reply other threads:[~2005-03-04 0:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-02 9:57 2.6.11-kj Domen Puncer
2005-03-04 0:25 ` Nishanth Aravamudan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050304002539.GE16078@us.ibm.com \
--to=nacc@us.ibm.com \
--cc=kernel-janitors@lists.osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome