From: Chuck Ebbert <76306.1226@compuserve.com>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: linux-ide <linux-ide@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Tejun Heo <htejun@gmail.com>
Subject: Re: [patch ide-dev 6/9] check capacity in ide_task_init_flush()
Date: Fri, 4 Mar 2005 03:52:57 -0500 [thread overview]
Message-ID: <200503040355_MC3-1-979D-F1DF@compuserve.com> (raw)
On Thu, 24 Feb 2005 at 15:44:34, Bartlomiej Zolnierkiewicz wrote:
> --- a/drivers/ide/ide-io.c 2005-02-23 20:58:16 +01:00
> +++ b/drivers/ide/ide-io.c 2005-02-23 20:58:16 +01:00
> @@ -61,7 +61,8 @@
>
> memset(task, 0, sizeof(*task));
>
> - if (ide_id_has_flush_cache_ext(drive->id)) {
> + if (ide_id_has_flush_cache_ext(drive->id) &&
> + (drive->capacity64 >= (1UL << 28))) {
^^
------------------------------>||
> tf->command = WIN_FLUSH_CACHE_EXT;
> tf->flags |= ATA_TFLAG_LBA48;
> } else
Shouldn't that be ">" ???
Either that or this code from ide-disk is wrong:
/* limit drive capacity to 137GB if LBA48 cannot be used */
if (drive->addressing == 0 && drive->capacity64 > 1ULL << 28) {
printk(KERN_WARNING "%s: cannot use LBA48 - full capacity "
"%llu sectors (%llu MB)\n",
drive->name, (unsigned long long)drive->capacity64,
sectors_to_MB(drive->capacity64));
drive->capacity64 = 1ULL << 28;
}
--
Chuck
next reply other threads:[~2005-03-04 9:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-04 8:52 Chuck Ebbert [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-02-24 14:44 Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200503040355_MC3-1-979D-F1DF@compuserve.com \
--to=76306.1226@compuserve.com \
--cc=bzolnier@gmail.com \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®