From: Andrew Morton <akpm@osdl.org>
To: Badari Pulavarty <pbadari@us.ibm.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] 2.6.11-mm1 "nobh" support for ext3 writeback mode
Date: Fri, 4 Mar 2005 16:45:53 -0800 [thread overview]
Message-ID: <20050304164553.29811e8f.akpm@osdl.org> (raw)
In-Reply-To: <1109982557.7236.65.camel@dyn318077bld.beaverton.ibm.com>
Badari Pulavarty <pbadari@us.ibm.com> wrote:
>
> > What's all this doing? (It needs comments please - it's very unobvious).
>
> All its trying to do is - to make sure the page is uptodate so that
> it can zero out the portion thats needed.
OK.
> I can do getblock() and ll_rw_block(READ) instead. I was
> trying to re-use the code and mpage_readpage() drops the lock.
> What do you think ?
Can you just call ->prepare_write, as nobh_truncate_page() does? That'll
cause a nested transaction, but that's legal.
next prev parent reply other threads:[~2005-03-05 0:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-05 0:02 Badari Pulavarty
2005-03-05 0:23 ` Andrew Morton
2005-03-05 0:29 ` Badari Pulavarty
2005-03-05 0:45 ` Andrew Morton [this message]
2005-03-05 0:49 ` Badari Pulavarty
2005-03-05 1:02 ` Badari Pulavarty
2005-03-05 1:16 ` Andrew Morton
2005-03-05 17:39 ` Badari Pulavarty
2005-03-05 0:31 ` Andrew Morton
2005-03-05 0:46 ` Badari Pulavarty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050304164553.29811e8f.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbadari@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®