From: Willy Tarreau <willy@w.ods.org>
To: Coywolf Qi Hunt <coywolf@gmail.com>
Cc: linux-kernel@vger.kernel.org, greg@kroah.com, akpm@osdl.org
Subject: Re: [patch] remove the `.' in EXTRAVERSION usage
Date: Sat, 5 Mar 2005 11:39:56 +0100 [thread overview]
Message-ID: <20050305103956.GH30106@alpha.home.local> (raw)
In-Reply-To: <2cd57c90050305022211b94e86@mail.gmail.com>
On Sat, Mar 05, 2005 at 06:22:45PM +0800, Coywolf Qi Hunt wrote:
> Since 2.6.9, there came along the LOCALVERSION for people to add local
> version in make menuconfig which was EXTRAVERSION originally for imho.
> Now EXTRAVERSION goes just as a kernel version number, it's reasonable
> to remove the `.' in its usage.
>
> Signed-off-by: Coywolf Qi Hunt <coywolf@gmail.com>
>
> diff -Nrup 2.6.11/Makefile 2.6.11-cy/Makefile
> --- 2.6.11/Makefile 2005-03-03 17:10:57.000000000 +0800
> +++ 2.6.11-cy/Makefile 2005-03-05 16:40:46.000000000 +0800
> @@ -1,7 +1,7 @@
> VERSION = 2
> PATCHLEVEL = 6
> SUBLEVEL = 11
> -EXTRAVERSION =
> +EXTRAVERSION = 1
> NAME=Woozy Numbat
>
> # *DOCUMENTATION*
> @@ -158,7 +158,7 @@ LOCALVERSION = $(subst $(space),, \
> $(shell cat /dev/null $(localver)) \
> $(patsubst "%",%,$(CONFIG_LOCALVERSION)))
>
> -KERNELRELEASE=$(VERSION).$(PATCHLEVEL).$(SUBLEVEL)$(EXTRAVERSION)$(LOCALVERSION)
> +KERNELRELEASE=$(VERSION).$(PATCHLEVEL).$(SUBLEVEL).$(EXTRAVERSION)$(LOCALVERSION)
Please don't do that, you'll always end up with a trailing dot in 3-numbers
versions. Eg: V=2 P=6 S=11 => "2.6.11."
Willy
next prev parent reply other threads:[~2005-03-05 10:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-05 10:22 Coywolf Qi Hunt
2005-03-05 10:39 ` Willy Tarreau [this message]
2005-03-05 11:47 ` Alexey Dobriyan
2005-03-05 11:07 ` Coywolf Qi Hunt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050305103956.GH30106@alpha.home.local \
--to=willy@w.ods.org \
--cc=akpm@osdl.org \
--cc=coywolf@gmail.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®