Re: [PATCH] kconfig: DEBUG_PAGEALLOC and SOFTWARE_SUSPEND are incompatible on i386

[Pavel Machek <pavel@ucw.cz>]

On Ne 06-03-05 21:12:41, Barry K. Nathan wrote:
> On i386, SOFTWARE_SUSPEND requires the CPU to have PSE support, but
> DEBUG_PAGEALLOC disables PSE. Thus, allowing both options to be enabled
> simultaneously makes no sense. This patch disables DEBUG_PAGEALLOC if
> SOFTWARE_SUSPEND is enabled; it also displays a comment to briefly
> explain why DEBUG_PAGEALLOC is missing in that case.

ACK.
									Pavel

> --- linux-2.6.11-bk2/arch/i386/Kconfig.debug	2004-12-24 13:34:45.000000000 -0800
> +++ linux-2.6.11-bk2-bkn2/arch/i386/Kconfig.debug	2005-03-06 20:59:07.000000000 -0800
> @@ -38,9 +38,12 @@
>  
>  	  This option will slow down process creation somewhat.
>  
> +comment "Page alloc debug is incompatible with Software Suspend on i386"
> +	depends on DEBUG_KERNEL && SOFTWARE_SUSPEND
> +
>  config DEBUG_PAGEALLOC
>  	bool "Page alloc debugging"
> -	depends on DEBUG_KERNEL
> +	depends on DEBUG_KERNEL && !SOFTWARE_SUSPEND
>  	help
>  	  Unmap pages from the kernel linear mapping after free_pages().
>  	  This results in a large slowdown, but helps to find certain types

-- 
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!