From: Alexey Dobriyan <adobriyan@mail.ru>
To: Benoit Boissinot <benoit.boissinot@ens-lyon.org>
Cc: Vojtech Pavlik <vojtech@suse.cz>, Andrew Morton <akpm@osdl.org>,
Greg KH <greg@kroah.com>,
torvalds@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [patch] fix NULL pointer deference in ALPS
Date: Mon, 7 Mar 2005 16:06:33 +0200 [thread overview]
Message-ID: <200503071606.33984.adobriyan@mail.ru> (raw)
In-Reply-To: <20050307122432.GG8138@ens-lyon.fr>
On Monday 07 March 2005 14:24, Benoit Boissinot wrote:
> alps_get_model returns a pointer or NULL in case of errors, so we need to
> check for the results being NULL, not negative.
2.6.11-bk2: int alps_get_model(struct psmouse *psmouse)
takes 1 argument, returns -1 on error
2.6.11-mm1: static struct alps_model_info *alps_get_model(struct psmouse *psmouse, int *version)
takes 2 arguments, returns NULL on error
> --- linux-clean/drivers/input/mouse/alps.c
> +++ linux-vanilla/drivers/input/mouse/alps.c
> - if ((model = alps_get_model(psmouse)) < 0)
> + if (!(model = alps_get_model(psmouse)))
> - if ((model = alps_get_model(psmouse)) < 0)
> + if (!(model = alps_get_model(psmouse)))
> - if (alps_get_model(psmouse) < 0)
> + if (!alps_get_model(psmouse))
To what version of kernel this patch should be applied?
Alexey
next prev parent reply other threads:[~2005-03-07 13:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-07 12:24 Benoit Boissinot
2005-03-07 13:10 ` Vojtech Pavlik
2005-03-07 13:11 ` Vojtech Pavlik
2005-03-07 14:06 ` Alexey Dobriyan [this message]
2005-03-07 13:12 ` Benoit Boissinot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200503071606.33984.adobriyan@mail.ru \
--to=adobriyan@mail.ru \
--cc=akpm@osdl.org \
--cc=benoit.boissinot@ens-lyon.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
--cc=vojtech@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®