From: Matt Mackall <mpm@selenic.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>, Andrew Morton <akpm@osdl.org>
Cc: Linux Kernel Development <linux-kernel@vger.kernel.org>
Subject: [PATCH] rol/ror type cleanup
Date: Thu, 10 Mar 2005 14:03:29 -0800 [thread overview]
Message-ID: <20050310220329.GN3120@waste.org> (raw)
In-Reply-To: <Pine.LNX.4.62.0503101032500.9286@numbat.sonytel.be>
On Thu, Mar 10, 2005 at 10:33:29AM +0100, Geert Uytterhoeven wrote:
> `unsigned int', while we're at it?
Minor type cleanup.
Signed-off-by: Matt Mackall <mpm@selenic.com>
Index: bk/include/linux/bitops.h
===================================================================
--- bk.orig/include/linux/bitops.h 2005-03-10 13:52:49.000000000 -0800
+++ bk/include/linux/bitops.h 2005-03-10 13:59:51.000000000 -0800
@@ -140,7 +140,7 @@ static inline unsigned long hweight_long
* @word: value to rotate
* @shift: bits to roll
*/
-static inline __u32 rol32(__u32 word, int shift)
+static inline __u32 rol32(__u32 word, unsigned int shift)
{
return (word << shift) | (word >> (32 - shift));
}
@@ -151,7 +151,7 @@ static inline __u32 rol32(__u32 word, in
* @word: value to rotate
* @shift: bits to roll
*/
-static inline __u32 ror32(__u32 word, int shift)
+static inline __u32 ror32(__u32 word, unsigned int shift)
{
return (word >> shift) | (word << (32 - shift));
}
--
Mathematics is the supreme nostalgia of our time.
prev parent reply other threads:[~2005-03-10 22:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200503082005.j28K5lBp028415@hera.kernel.org>
2005-03-10 9:33 ` [PATCH] random: Create new rol32/ror32 bitops Geert Uytterhoeven
2005-03-10 22:03 ` Matt Mackall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050310220329.GN3120@waste.org \
--to=mpm@selenic.com \
--cc=akpm@osdl.org \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®