From: Ingo Molnar <mingo@elte.hu>
To: Scott Wood <scott@gw.timesys.com>
Cc: linux-kernel@vger.kernel.org, manas.saksena@timesys.com
Subject: Re: [PATCH] realtime-preempt: update inherited priorities on setscheduler
Date: Fri, 11 Mar 2005 10:36:07 +0100 [thread overview]
Message-ID: <20050311093607.GB19954@elte.hu> (raw)
In-Reply-To: <20050310212116.GA2420@yoda.timesys>
* Scott Wood <scott@gw.timesys.com> wrote:
> - p->prio = effective_prio(p);
> + /* Don't overwrite an inherited RT priority with the static
> + RT priority. */
> +
> + if (!rt_task(p))
> + p->prio = effective_prio(p);
are you sure this is needed? The -RT code currently does this:
static int effective_prio(task_t *p)
{
if (rt_task(p))
return p->prio;
return __effective_prio(p);
}
i.e. if it's an RT task then 'effective priority' is whatever it has
right now. I.e. 'p->prio = effective_prio(p)' will have no effect for RT
tasks. PI would not be working at all if we were overwriting the
inherited priority.
Ingo
next prev parent reply other threads:[~2005-03-11 9:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-10 21:21 Scott Wood
2005-03-11 9:36 ` Ingo Molnar [this message]
2005-03-11 16:19 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050311093607.GB19954@elte.hu \
--to=mingo@elte.hu \
--cc=linux-kernel@vger.kernel.org \
--cc=manas.saksena@timesys.com \
--cc=scott@gw.timesys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®