From: Andrew Morton <akpm@osdl.org>
To: Johannes Stezenbach <js@linuxtv.org>
Cc: cherry@osdl.org, linux-kernel@vger.kernel.org, kraxel@bytesex.org
Subject: Re: IA32 (2.6.11 - 2005-03-12.16.00) - 56 New warnings
Date: Sun, 13 Mar 2005 11:35:00 -0800 [thread overview]
Message-ID: <20050313113500.59e57a87.akpm@osdl.org> (raw)
In-Reply-To: <20050313124333.GA26569@linuxtv.org>
Johannes Stezenbach <js@linuxtv.org> wrote:
>
> On Sat, Mar 12, 2005 at 09:08:45PM -0800, John Cherry wrote:
> > drivers/media/dvb/frontends/dvb-pll.c:104: warning: (near initialization for `dvb_pll_unknown_1.entries')
> > drivers/media/dvb/frontends/dvb-pll.c:104: warning: excess elements in array initializer
> > drivers/media/dvb/frontends/dvb-pll.c:105: warning: (near initialization for `dvb_pll_unknown_1.entries')
> > drivers/media/dvb/frontends/dvb-pll.c:105: warning: excess elements in array initializer
> [snip]
>
> Gerd's original patch had
>
> struct dvb_pll_desc {
> char *name;
> u32 min;
> u32 max;
> void (*setbw)(u8 *buf, int bandwidth);
> int count;
> struct {
> u32 limit;
> u32 offset;
> u32 stepsize;
> u8 cb1;
> u8 cb2;
> } entries[];
> };
>
> while 2.6.11-mm3 changed it into entries[0].
The original code failed to compile with gcc-2.95.4, so I stuck the [0] in
there, then was vaguely surprised when no warnings came out. Seems that
later compilers _do_ warn.
I guess we could put a 9 in there.
next prev parent reply other threads:[~2005-03-13 19:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-13 5:08 John Cherry
2005-03-13 12:43 ` Johannes Stezenbach
2005-03-13 19:35 ` Andrew Morton [this message]
2005-03-14 9:41 ` Gerd Knorr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050313113500.59e57a87.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=cherry@osdl.org \
--cc=js@linuxtv.org \
--cc=kraxel@bytesex.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®