mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jesse Barnes <jbarnes@engr.sgi.com>
To: akpm@osdl.org, pfg@sgi.com, linux-kernel@vger.kernel.org
Subject: [PATCH] gcc4 fix for sn_serial.c
Date: Mon, 14 Mar 2005 11:32:39 -0800	[thread overview]
Message-ID: <200503141132.39284.jbarnes@engr.sgi.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 540 bytes --]

The sal_console and sal_console_uart structures have a circular relationship 
since they both initialize member fields to pointers of one another.  The 
current code forward declares sal_console_uart as extern so that sal_console 
can take its address, but gcc4 complains about this since the real definition 
of sal_console_uart is marked 'static'.  This patch just removes the static 
qualifier from sal_console_uart to avoid the inconsistency.  Does it look ok 
to you, Pat?

Signed-off-by: Jesse Barnes <jbarnes@sgi.com>

Thanks,
Jesse

[-- Attachment #2: sn-serial-gcc4-fix.patch --]
[-- Type: text/plain, Size: 414 bytes --]

===== drivers/serial/sn_console.c 1.12 vs edited =====
--- 1.12/drivers/serial/sn_console.c	2005-03-07 20:41:31 -08:00
+++ edited/drivers/serial/sn_console.c	2005-03-14 10:57:19 -08:00
@@ -801,7 +801,7 @@
 
 #define SAL_CONSOLE	&sal_console
 
-static struct uart_driver sal_console_uart = {
+struct uart_driver sal_console_uart = {
 	.owner = THIS_MODULE,
 	.driver_name = "sn_console",
 	.dev_name = DEVICE_NAME,

             reply	other threads:[~2005-03-14 19:33 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-03-14 19:32 Jesse Barnes [this message]
2005-03-15  1:03 ` Adrian Bunk
2005-03-15 17:48   ` Jesse Barnes
2005-04-26 22:58     ` Andreas Schwab
2005-04-26 23:09       ` Andreas Schwab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200503141132.39284.jbarnes@engr.sgi.com \
    --to=jbarnes@engr.sgi.com \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pfg@sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®