mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: Adrian Bunk <bunk@stusta.de>
Cc: kraxel@bytesex.org, linux-kernel@vger.kernel.org
Subject: Re: 2.6.11-mm3: saa7134-core.c compile error
Date: Mon, 14 Mar 2005 20:38:22 -0800	[thread overview]
Message-ID: <20050314203822.08b9c63e.akpm@osdl.org> (raw)
In-Reply-To: <20050312131813.GA3814@stusta.de>

Adrian Bunk <bunk@stusta.de> wrote:
>
> On Sat, Mar 12, 2005 at 03:42:22AM -0800, Andrew Morton wrote:
>  >...
>  > Changes since 2.6.11-mm2:
>  >...
>  > +saa7134-update.patch
>  >...
>  >  v4l updates
>  >...
> 
>  This doesn't compile with CONFIG_MODULES=n:
> 
>  <--  snip  -->
> 
>  ...
>    CC      drivers/media/video/saa7134/saa7134-core.o
>  drivers/media/video/saa7134/saa7134-core.c: In function `saa7134_fini':
>  drivers/media/video/saa7134/saa7134-core.c:1215: error: `pending_registered' undeclared (first use in this function)

Like this, I guess:

--- 25/drivers/media/video/saa7134/saa7134-core.c~saa7134-build-fix	2005-03-14 20:37:16.000000000 -0800
+++ 25-akpm/drivers/media/video/saa7134/saa7134-core.c	2005-03-14 20:37:27.000000000 -0800
@@ -1212,8 +1212,10 @@ static int saa7134_init(void)
 
 static void saa7134_fini(void)
 {
+#ifdef CONFIG_MODULES
 	if (pending_registered)
 		unregister_module_notifier(&pending_notifier);
+#endif
 	pci_unregister_driver(&saa7134_pci_driver);
 }
 
_


  reply	other threads:[~2005-03-15  4:42 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-03-12 11:42 2.6.11-mm3 Andrew Morton
2005-03-12 12:20 ` 2.6.11-mm3 Jens Axboe
2005-03-12 12:41 ` 2.6.11-mm3 Reuben Farrelly
2005-03-12 15:51   ` 2.6.11-mm3 Anton Altaparmakov
2005-03-12 13:18 ` 2.6.11-mm3: saa7134-core.c compile error Adrian Bunk
2005-03-15  4:38   ` Andrew Morton [this message]
2005-03-15 17:47     ` Adrian Bunk
2005-03-12 13:40 ` 2.6.11-mm3 Ed Tomlinson
2005-03-12 15:52   ` 2.6.11-mm3 Anton Altaparmakov
2005-03-12 15:55 ` [2.6 patch] drivers/net/sis900.c: fix a warning Adrian Bunk
2005-03-12 17:30 ` [2.6 patch] drivers/video/intelfb/: " Adrian Bunk
2005-03-12 19:13 ` DRI breakage, 2.6.11-mm[123] Sean Neakums
2005-03-12 19:29   ` Sean Neakums
2005-03-12 23:13     ` Dave Airlie
2005-03-12 23:58       ` Dave Jones
2005-03-13 12:48         ` Sean Neakums
2005-03-13 13:34           ` Dave Airlie
2005-03-13 12:01 ` 2.6.11-mm3: machine check on sleep, PowerBook5.4 Sean Neakums
2005-03-13 12:23   ` Benjamin Herrenschmidt
2005-03-13 12:30   ` Benjamin Herrenschmidt
2005-03-13 12:35     ` Benjamin Herrenschmidt
2005-03-13 16:19       ` Sean Neakums
2005-03-13 19:07         ` Sean Neakums
2005-03-13 21:53           ` Benjamin Herrenschmidt
2005-03-13 22:08             ` Sean Neakums
2005-03-13 22:10               ` Benjamin Herrenschmidt
2005-03-13 22:12               ` Benjamin Herrenschmidt
2005-03-13 21:47         ` Benjamin Herrenschmidt
2005-03-13 16:31 ` 2.6.11-mm3 Barry K. Nathan
2005-03-14 16:25 ` 2.6.11-mm3 (compile stats) John Cherry
2005-03-14 21:54 ` 2.6.11-mm3 - DRM/i915 broken Brice Goglin
2005-03-14 22:30   ` Bernhard Rosenkraenzer
2005-03-14 22:57     ` Brice Goglin
2005-03-16  9:36       ` Dave Airlie
2005-03-17 18:57         ` Brice Goglin
2005-03-19  2:45         ` Fix agp_backend usage in drm_agp_init (was: 2.6.11-mm3 - DRM/i915 broken) Brice Goglin
2005-03-19  3:40           ` Jesse Barnes
2005-03-19  3:48             ` Jesse Barnes
2005-03-19 16:32               ` Jesse Barnes
     [not found]           ` <200503191247.48963.werner@sgi.com>
     [not found]             ` <21d7e9970503231247179b7c46@mail.gmail.com>
2005-03-24  8:45               ` Dave Airlie
2005-03-16 18:57       ` 2.6.11-mm3 - DRM/i915 broken Ruben Fonseca
2005-03-15  7:57 ` 2.6.11-mm3 Stefano Rivoir
2005-03-15 12:25 ` 2.6.11-mm3 mouse oddity Helge Hafting
2005-03-15 14:25   ` Dmitry Torokhov
2005-03-15 14:36     ` Vojtech Pavlik
2005-03-15 19:01     ` Andrew Morton
2005-03-15 19:33       ` Dave Jones
2005-03-15 19:34       ` Dmitry Torokhov
2005-03-15 19:54         ` Sean
2005-03-15 20:10       ` Vojtech Pavlik
2005-03-16  9:47         ` Helge Hafting
2005-03-16 17:29           ` Vojtech Pavlik
2005-03-16  9:44       ` Helge Hafting
2005-03-16 17:30         ` Vojtech Pavlik
2005-03-17 11:09           ` Helge Hafting
2005-03-17 12:14             ` Vojtech Pavlik
2005-03-15 15:06 ` 2.6.11-mm3: megaraid_sas.c: stack usage Adrian Bunk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050314203822.08b9c63e.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=bunk@stusta.de \
    --cc=kraxel@bytesex.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®