From: Andrew Morton <akpm@osdl.org>
To: Prarit Bhargava <prarit@sgi.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC]: DEBUG for PCI IO & MEM allocation
Date: Mon, 14 Mar 2005 21:28:12 -0800 [thread overview]
Message-ID: <20050314212812.3657cfd4.akpm@osdl.org> (raw)
In-Reply-To: <4235C88B.9090708@sgi.com>
Prarit Bhargava <prarit@sgi.com> wrote:
>
> I propose the following patch to add a compile time DEBUG option to
> kernel/resource.c that would help in analyzing problems in this area.
> It's a few simple lines of output in __request_resource,
> __release_resource, __request_region, and __release_region .
>
A sane enough requirement.
>
> + DEBUGP("%s: resource request at 0x%lx-0x%lx\n", __FUNCTION__, new->start, new->end);
Shouldn't this also be printing the ->name of the new resource?
A lot of the statements which you're adding will look screwy in an 80-col
xterm. Please wrap 'em.
next prev parent reply other threads:[~2005-03-15 5:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-14 17:23 Prarit Bhargava
2005-03-15 5:28 ` Andrew Morton [this message]
2005-03-21 20:03 ` Prarit Bhargava
2005-03-22 6:04 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050314212812.3657cfd4.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=prarit@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome