From: Andrew Morton <akpm@osdl.org>
To: "Enrico Bartky" <DOSProfi@web.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: SMbus not enabled
Date: Mon, 14 Mar 2005 22:24:31 -0800 [thread overview]
Message-ID: <20050314222431.1d64f84c.akpm@osdl.org> (raw)
In-Reply-To: <833993817@web.de>
"Enrico Bartky" <DOSProfi@web.de> wrote:
>
> my notebook have a SiS 964 Chipset and "quirked" by "quirk_sis_503", ...
> but there is no SMbus device. If I add a call to the "quirk_sis_96x_smbus"
> function directly from the "quirk_sis_503" function, the smbus is present,
> but I think a call to a quirk from a quirk is not optimal. Is there a better
> solution?
(Please wrap your email lines before column 80)
What version of the kernel are you using?
I assume that you mean that the machine does have SMBus, but that it is not
being recognised by the kernel?
It could be that we don't have the appropriate PCI IDs in there. Please
run `lspci -vvxx' and send the part which is relevant to the SMBus
interface.
Also, in drivers/pci/quirks.c you can change `#undef DEBUG' to `#define
DEBUG' and it will print useful information.
This patch will help, too:
--- 25/drivers/pci/quirks.c~a 2005-03-14 22:23:08.000000000 -0800
+++ 25-akpm/drivers/pci/quirks.c 2005-03-14 22:23:57.000000000 -0800
@@ -1262,6 +1262,8 @@ DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_IN
static void pci_do_fixups(struct pci_dev *dev, struct pci_fixup *f, struct pci_fixup *end)
{
while (f < end) {
+ pr_debug(PCI: quirks: inspecting %04x:%04x\n",
+ dev->vendor, dev->device);
if ((f->vendor == dev->vendor || f->vendor == (u16) PCI_ANY_ID) &&
(f->device == dev->device || f->device == (u16) PCI_ANY_ID)) {
pr_debug("PCI: Calling quirk %p for %s\n", f->hook, pci_name(dev));
_
prev parent reply other threads:[~2005-03-15 6:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-14 22:05 Enrico Bartky
2005-03-15 6:24 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050314222431.1d64f84c.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=DOSProfi@web.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome