From: Matt Mackall <mpm@selenic.com>
To: linux-kernel <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>
Subject: [PATCH] reduce __deprecated spew
Date: Mon, 14 Mar 2005 22:34:36 -0800 [thread overview]
Message-ID: <20050315063436.GN32638@waste.org> (raw)
This patch changes a couple of the noisier deprecations to only warn
on the primary entrypoint (in these cases, the _register functions).
This approach makes it obvious that an interface is going away while
only warning once per user. I suggest we adopt this approach for
future deprecation campaigns.
Signed-off-by: Matt Mackall <mpm@selenic.com>
Index: bk/include/linux/pm.h
===================================================================
--- bk.orig/include/linux/pm.h 2005-03-14 22:14:59.000000000 -0800
+++ bk/include/linux/pm.h 2005-03-14 22:17:48.000000000 -0800
@@ -108,17 +108,17 @@ struct pm_dev __deprecated *pm_register(
/*
* Unregister a device with power management
*/
-void __deprecated pm_unregister(struct pm_dev *dev);
+void /*deprecated*/ pm_unregister(struct pm_dev *dev);
/*
* Unregister all devices with matching callback
*/
-void __deprecated pm_unregister_all(pm_callback callback);
+void /*deprecated*/ pm_unregister_all(pm_callback callback);
/*
* Send a request to all devices
*/
-int __deprecated pm_send_all(pm_request_t rqst, void *data);
+int /*deprecated*/ pm_send_all(pm_request_t rqst, void *data);
#else /* CONFIG_PM */
Index: bk/include/linux/module.h
===================================================================
--- bk.orig/include/linux/module.h 2005-03-14 22:14:59.000000000 -0800
+++ bk/include/linux/module.h 2005-03-14 22:17:50.000000000 -0800
@@ -562,9 +562,9 @@ __MODULE_PARM_TYPE(var, type);
#define HAVE_INTER_MODULE
extern void __deprecated inter_module_register(const char *,
struct module *, const void *);
-extern void __deprecated inter_module_unregister(const char *);
-extern const void * __deprecated inter_module_get_request(const char *,
+extern void /*deprecated*/ inter_module_unregister(const char *);
+extern const void * /*deprecated*/ inter_module_get_request(const char *,
const char *);
-extern void __deprecated inter_module_put(const char *);
+extern void /*deprecated*/ inter_module_put(const char *);
#endif /* _LINUX_MODULE_H */
--
Mathematics is the supreme nostalgia of our time.
next reply other threads:[~2005-03-15 6:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-15 6:34 Matt Mackall [this message]
2005-03-15 6:42 ` Andrew Morton
2005-03-15 7:16 ` Arjan van de Ven
2005-03-15 13:38 ` Josh Boyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050315063436.GN32638@waste.org \
--to=mpm@selenic.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®