Re: [Patch] x86, x86_64: Intel dual-core detection

["Siddha, Suresh B" <suresh.b.siddha@intel.com>]

On Wed, Mar 16, 2005 at 06:04:12PM +0100, Andi Kleen wrote:
> On Tue, Mar 15, 2005 at 05:36:25PM -0800, Siddha, Suresh B wrote:
> > It adds two new fields "core id" and "cpu cores" to x86 /proc/cpuinfo
> > and the "core id" field for x86_64("cpu cores" field is already present in
> > x86_64).
> 
> Thanks. I have a similar patch for AMD CPUs, unfortuntely it uses 
> different names ("shared cores" etc.)

2.6.11 already has "cpu cores" for x86_64. I would like to retain that.

> > 
> > This patch also adds cpu_core_map similar to cpu_sibling_map.
> Called cpu_sharecore_map in my patch.

cpu_sharecore_map sounds like HT logical siblings sharing the core. Initially 
I was calling it as cpu_coresibling_map but later thought cpu_core_map is 
a smaller name.

> 
> Hmm, which names should be chosen?

For /proc/cpuinfo, I want to stick with "cpu cores" and "core id"
But I am open for kernel variable names.

Depending on what we decide on kernel variable names, I will see if I have 
to make any changes to the IPF patch we posted last week.

thanks,
suresh