From: Marcelo Tosatti <marcelo.tosatti@cyclades.com>
To: Jacques Basson <jacques_basson@myrealbox.com>
Cc: linux-kernel@vger.kernel.org, Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: softdog.c kernel 2.4.29
Date: Wed, 16 Mar 2005 09:19:07 -0300 [thread overview]
Message-ID: <20050316121907.GB12881@logos.cnet> (raw)
In-Reply-To: <1110959428.10190.5.camel@lancelot.advanced-imaging-technologies>
Hi Jacques
On Wed, Mar 16, 2005 at 09:50:27AM +0200, Jacques Basson wrote:
> Hi
>
> There is a bug in the softdog.c (v 0.05) in the 2.4 kernel series
> (certainly in 2.4.29 and there are no references to it in the latest
> Changelog) that won't reboot the machine if /dev/watchdog is closed
> unexpectedly and nowayout is not set.
Yup, thanks. Applied.
> diff -Naur softdog.c.orig softdog.c
> --- softdog.c.orig 2003-11-28 20:26:20.000000000 +0200
> +++ softdog.c 2005-03-16 09:12:34.000000000 +0200
> @@ -124,7 +124,7 @@
> * Shut off the timer.
> * Lock it in if it's a module and we set nowayout
> */
> - if (expect_close || nowayout == 0) {
> + if (expect_close && nowayout == 0) {
> del_timer(&watchdog_ticktock);
> } else {
> printk(KERN_CRIT "SOFTDOG: WDT device closed
> unexpectedly. WDT will not stop!\n");
prev parent reply other threads:[~2005-03-16 17:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-16 7:50 Jacques Basson
2005-03-16 12:19 ` Marcelo Tosatti [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050316121907.GB12881@logos.cnet \
--to=marcelo.tosatti@cyclades.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=jacques_basson@myrealbox.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®