mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Stelian Pop <stelian.pop@fr.alcove.com>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: Larry McVoy <lm@bitmover.com>
Subject: BKCVS broken ?
Date: Thu, 17 Mar 2005 15:45:22 +0100	[thread overview]
Message-ID: <20050317144522.GK22936@hottah.alcove-fr> (raw)

The current bkcvs export is broken, several recent changesets are
missing from it.

This occurs at least in the mm/ directory, but I haven't verified
if other directories are not affected. I detected this problem
because the head of bkcvs doesn't compile anymore and shows errors
in mm/* missing symbols.

One example:

Take this changeset from Changeset,v:
-------------------------------------------------------------
1.27702
log
@[PATCH] orphaned pagecache memleak fix

Chris found that with data journaling a reiserfs pagecache may be truncate
while still pinned.  The truncation removes the page->mapping, but the page
is still listed in the VM queues because it still has buffers.  Then during
the journaling process, a buffer is marked dirty and that sets the PG_dirty
bitflag as well (in mark_buffer_dirty).  After that the page is leaked
because it's both dirty and without a mapping.

So we must allow pages without mapping and dirty to reach the PagePrivate
check.  The page->mapping will be checked again right after the PagePrivate
check.

Signed-off-by: Andrea Arcangeli <andrea@@suse.de>
Signed-off-by: Andrew Morton <akpm@@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@@osdl.org>

BKrev: 4234d7beMW4wcFI6ltxdMMhApwDmuA
-------------------------------------------------------------

Looking at
http://linux.bkbits.net:8080/linux-2.6/gnupatch@4234d7beMW4wcFI6ltxdMMhApwDmuA
shows this changeset should contain a delta for mm/vmscan.c

However, mm/vmscan.c,v contains:
-------------------------------------------------------------
head    1.238;  
access;
symbols;
locks; strict; 
comment @ * @;
expand  @o@;


1.238
date    2005.03.10.17.06.39;    author pj;      state Exp;
branches;
next    1.237;  
....
1.238
log
@cpusets - big numa cpu and memory placement

(Logical change 1.27465)
@
-------------------------------------------------------------

The 'Logical change 1.27702' is missing from the file...

Stelian.
-- 
Stelian Pop <stelian.pop@fr.alcove.com>
Alcove - http://www.alcove.com

             reply	other threads:[~2005-03-17 14:45 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-03-17 14:45 Stelian Pop [this message]
2005-03-17 15:43 ` Catalin Marinas
2005-03-17 15:44 ` Larry McVoy
2005-03-18  3:07   ` H. Peter Anvin
2005-03-18  0:10 ` Larry McVoy
2005-03-18  5:50   ` Erik Andersen
2005-03-18  6:38     ` Larry McVoy
2005-03-18  9:00       ` Stelian Pop
2005-03-18 14:13         ` Larry McVoy
2005-03-18 14:21           ` Stelian Pop
2005-03-18 15:08             ` Hong Kong Phoey
2005-03-18 22:09               ` Stelian Pop
2005-03-19 14:52 ` Larry McVoy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050317144522.GK22936@hottah.alcove-fr \
    --to=stelian.pop@fr.alcove.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lm@bitmover.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®