From: Martin Schwidefsky <schwidefsky@de.ibm.com>
To: akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: [patch 5/8] s390: s390dbf permissions.
Date: Thu, 17 Mar 2005 15:56:59 +0100 [thread overview]
Message-ID: <20050317145659.GE4807@mschwid3.boeblingen.de.ibm.com> (raw)
[patch 5/8] s390: s390dbf permissions.
From: Michael Holzheu <holzheu@de.ibm.com>
Use more specific permissions for the procfiles if s390dbf. Read only
views should have read permission, write only views should have write
permission.
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
diffstat:
arch/s390/kernel/debug.c | 10 +++++-----
1 files changed, 5 insertions(+), 5 deletions(-)
diff -urN linux-2.6/arch/s390/kernel/debug.c linux-2.6-patched/arch/s390/kernel/debug.c
--- linux-2.6/arch/s390/kernel/debug.c 2005-03-02 08:37:48.000000000 +0100
+++ linux-2.6-patched/arch/s390/kernel/debug.c 2005-03-17 15:36:00.000000000 +0100
@@ -931,11 +931,15 @@
int rc = 0;
int i;
unsigned long flags;
- mode_t mode = S_IFREG | S_IRUSR | S_IWUSR;
+ mode_t mode = S_IFREG;
struct proc_dir_entry *pde;
if (!id)
goto out;
+ if (view->prolog_proc || view->format_proc || view->header_proc)
+ mode |= S_IRUSR;
+ if (view->input_proc)
+ mode |= S_IWUSR;
pde = create_proc_entry(view->name, mode, id->proc_root_entry);
if (!pde){
printk(KERN_WARNING "debug: create_proc_entry() failed! Cannot register view %s/%s\n", id->name,view->name);
@@ -958,10 +962,6 @@
}
else {
id->views[i] = view;
- if (view->prolog_proc || view->format_proc || view->header_proc)
- mode |= S_IRUSR;
- if (view->input_proc)
- mode |= S_IWUSR;
pde->proc_fops = &debug_file_ops;
id->proc_entries[i] = pde;
}
reply other threads:[~2005-03-17 14:59 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050317145659.GE4807@mschwid3.boeblingen.de.ibm.com \
--to=schwidefsky@de.ibm.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®